Add endpoint to process filters and return Identifiables attributes list #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basseche
changed the title
Signed-off-by: basseche <[email protected]>
basseche
force-pushed
the
FilterBasedContingencyList
branch
from
efb2158 to
6e9eda1
Compare
basseche
changed the title
Signed-off-by: basseche <[email protected]>
flomillot
approved these changes
Sep 18, 2025
| if (filterIdentiables.getNotFoundIds() != null) { | ||
| filterIdentiables.getNotFoundIds().forEach(element -> notFound.put(element.getId(), element)); | ||
| } | ||
| filterIdentiables.getEquipmentIds().forEach(element -> result.put(element.getId(), element)); |
There was a problem hiding this comment.
I would implement the same safety than upper
There was a problem hiding this comment.
you mean requireNonNull ?
There was a problem hiding this comment.
not a bad idea because if filter is absent we should better throw an exception than continue.
the problem is here we have the filter uuid and not abstract filter, so i think we should throw a custom exception since we can't make the same control on Optional.
thangqp
reviewed
Sep 23, 2025
src/main/java/org/gridsuite/filter/server/configs/RestTemplateConfig.java
Show resolved
Hide resolved
src/main/java/org/gridsuite/filter/server/FilterController.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Thang PHAM <[email protected]>
Co-authored-by: Thang PHAM <[email protected]>
thangqp
reviewed
Sep 24, 2025
thangqp
approved these changes
Sep 24, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs filter lib version : gridsuite/filter#84