create a specific exception for filter cycle detection (#89)

Author: benrejebmoh

src/main/java/org/gridsuite/filter/exceptions/FilterCycleException.java

@@ -0,0 +1,17 @@
+/*
+ *  Copyright (c) 2025, RTE (http://www.rte-france.com)
+ *  This Source Code Form is subject to the terms of the Mozilla Public
+ *  License, v. 2.0. If a copy of the MPL was not distributed with this
+ *  file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+package org.gridsuite.filter.exceptions;
+
+/**
+ * @author Mohamed BENREJEB <mohamed.ben-rejeb at rte-france.com>
+ */
+public class FilterCycleException extends RuntimeException {
+    public FilterCycleException(String message) {
+        super(message);
+    }
+}

src/main/java/org/gridsuite/filter/utils/expertfilter/FilterCycleDetector.java

@@ -7,9 +7,9 @@
 
 package org.gridsuite.filter.utils.expertfilter;
 
-import com.powsybl.commons.PowsyblException;
 import org.gridsuite.filter.AbstractFilter;
 import org.gridsuite.filter.FilterLoader;
+import org.gridsuite.filter.exceptions.FilterCycleException;
 import org.gridsuite.filter.expertfilter.ExpertFilter;
 import org.gridsuite.filter.expertfilter.expertrule.AbstractExpertRule;
 import org.gridsuite.filter.expertfilter.expertrule.CombinatorExpertRule;
@@ -44,7 +44,7 @@ private static void checkNoCycle(AbstractFilter filter, FilterLoader loader,
         UUID id = filter.getId();
         if (id != null) {
             if (visiting.contains(id)) {
-                throw new PowsyblException("Cycle detected in filters");
+                throw new FilterCycleException("Cycle detected in filters");
             }
             visiting.add(id);
         }

src/test/java/org/gridsuite/filter/utils/FilterCycleDetectorTest.java

@@ -6,9 +6,9 @@
  */
 package org.gridsuite.filter.utils;
 
-import com.powsybl.commons.PowsyblException;
 import org.gridsuite.filter.AbstractFilter;
 import org.gridsuite.filter.FilterLoader;
+import org.gridsuite.filter.exceptions.FilterCycleException;
 import org.gridsuite.filter.expertfilter.ExpertFilter;
 import org.gridsuite.filter.expertfilter.expertrule.AbstractExpertRule;
 import org.gridsuite.filter.expertfilter.expertrule.CombinatorExpertRule;
@@ -58,7 +58,7 @@ void testDetectCycleBetweenExpertFilters() {
         Map<UUID, AbstractFilter> filters = Map.of(filterIdA, filterA, filterIdB, filterB);
         FilterLoader loader = ids -> ids.stream().map(filters::get).toList();
 
-        PowsyblException ex = assertThrows(PowsyblException.class, () -> FilterCycleDetector.checkNoCycle(filterA, loader));
+        FilterCycleException ex = assertThrows(FilterCycleException.class, () -> FilterCycleDetector.checkNoCycle(filterA, loader));
         assertEquals("Cycle detected in filters", ex.getMessage());
     }
 
@@ -92,7 +92,7 @@ void testNoCycle() {
 
         try {
             FilterCycleDetector.checkNoCycle(filterA, loader);
-        } catch (PowsyblException e) {
+        } catch (FilterCycleException e) {
             fail("Unexpected cycle detected");
         }
     }