fix(): manage null substationIds ou lineIds

Signed-off-by: sBouzols <[email protected]>

Author: sBouzols

src/main/java/org/gridsuite/geodata/server/GeoDataService.java

@@ -178,7 +178,10 @@ private void prepareGeoDataForComputation(Network network, Map<String, Substatio
             neighboursToBeTreated.forEach(neighbourId -> {
                 if (geoDataForComputation.get(neighbourId) == null && !substationsToCalculate.contains(neighbourId)) {
                     substationsToCalculate.add(neighbourId);
-                    substations.add(network.getSubstation(neighbourId));
+                    Substation sub = network.getSubstation(neighbourId);
+                    if (sub != null) {
+                        substations.add(sub);
+                    }
                 }
             });
             Map<String, Set<String>> newNeighbours = getNeighbours(substations);
@@ -283,17 +286,19 @@ private void step(Step step, Network network, Map<String, Set<String>> sortedNei
             for (Iterator<String> it = substationsToCalculate.iterator(); it.hasNext();) {
                 String substationId = it.next();
                 Set<String> neighbours = sortedNeighbours.get(substationId);
-                double neighborhoodOffset = calculatedSubstationsOffset.get(neighbours) != null ? nextNeighborhoodOffset(calculatedSubstationsOffset.get(neighbours)) : 0;
-
-                // centroid calculation
-                Substation substation = network.getSubstation(substationId);
-                SubstationGeoData substationGeoData = calculateCentroidGeoData(substation, neighbours, step, substationsGeoData, neighborhoodOffset);
-
-                if (substationGeoData != null) {
-                    calculated++;
-                    substationsGeoData.put(substationId, substationGeoData);
-                    calculatedSubstationsOffset.put(neighbours, neighborhoodOffset);
-                    it.remove();
+                if (neighbours != null) {
+                    double neighborhoodOffset = calculatedSubstationsOffset.get(neighbours) != null ? nextNeighborhoodOffset(calculatedSubstationsOffset.get(neighbours)) : 0;
+
+                    // centroid calculation
+                    Substation substation = network.getSubstation(substationId);
+                    SubstationGeoData substationGeoData = calculateCentroidGeoData(substation, neighbours, step, substationsGeoData, neighborhoodOffset);
+
+                    if (substationGeoData != null) {
+                        calculated++;
+                        substationsGeoData.put(substationId, substationGeoData);
+                        calculatedSubstationsOffset.put(neighbours, neighborhoodOffset);
+                        it.remove();
+                    }
                 }
             }
             LOGGER.info("Step {}, iteration {}, {} substation's coordinates have been calculated, {} remains unknown",
@@ -536,7 +541,12 @@ public List<LineGeoData> getLinesByIds(Network network, Set<String> linesIds) {
 
         List<Line> lines = new ArrayList<>();
 
-        linesIds.forEach(id -> lines.add(network.getLine(id)));
+        linesIds.forEach(id -> {
+            Line line = network.getLine(id);
+            if (line != null) {
+                lines.add(line);
+            }
+        });
 
         // read lines from DB
         Map<String, LineGeoData> linesGeoDataDb = lineRepository.findAllById(linesIds).stream().collect(Collectors.toMap(LineEntity::getId, this::toDto));

src/test/java/org/gridsuite/geodata/server/GeoDataControllerTest.java

@@ -162,6 +162,18 @@ void test() throws Exception {
                 .andExpect(content().contentTypeCompatibleWith(APPLICATION_JSON))
                 .andExpect(jsonPath("$", hasSize(0)));
 
+        mvc.perform(get("/" + VERSION + "/substations?networkUuid=" + networkUuid + "&variantId=" + VARIANT_ID + "&substationId=null&substationId=P2")
+                .contentType(APPLICATION_JSON))
+                .andExpect(status().isOk())
+                .andExpect(content().contentTypeCompatibleWith(APPLICATION_JSON))
+                .andExpect(jsonPath("$", hasSize(0)));
+
+        mvc.perform(get("/" + VERSION + "/substations?networkUuid=" + networkUuid + "&variantId=" + VARIANT_ID + "&substationId=null")
+                .contentType(APPLICATION_JSON))
+                .andExpect(status().isOk())
+                .andExpect(content().contentTypeCompatibleWith(APPLICATION_JSON))
+                .andExpect(jsonPath("$", hasSize(0)));
+
         mvc.perform(get("/" + VERSION + "/lines?networkUuid=" + networkUuid + "&variantId=" + VARIANT_ID + "&lineId=NHV1_NHV2_2&lineId=NHV1_NHV2_1&country=" + Country.FR)
                         .contentType(APPLICATION_JSON))
                 .andExpect(status().isOk())
@@ -173,6 +185,18 @@ void test() throws Exception {
                 .andExpect(status().isOk())
                 .andExpect(content().contentTypeCompatibleWith(APPLICATION_JSON))
                 .andExpect(jsonPath("$", hasSize(0)));
+
+        mvc.perform(get("/" + VERSION + "/lines?networkUuid=" + networkUuid + "&variantId=" + VARIANT_ID + "&lineId=NHV1_NHV2_2&lineId=null")
+                .contentType(APPLICATION_JSON))
+                .andExpect(status().isOk())
+                .andExpect(content().contentTypeCompatibleWith(APPLICATION_JSON))
+                .andExpect(jsonPath("$", hasSize(0)));
+
+        mvc.perform(get("/" + VERSION + "/lines?networkUuid=" + networkUuid + "&variantId=" + VARIANT_ID + "&lineId=null")
+                .contentType(APPLICATION_JSON))
+                .andExpect(status().isOk())
+                .andExpect(content().contentTypeCompatibleWith(APPLICATION_JSON))
+                .andExpect(jsonPath("$", hasSize(0)));
     }
 
     @Test