comments

Signed-off-by: sBouzols <[email protected]>

Author: sBouzols

.gitignore

@@ -1,6 +1,7 @@
 # VSCode
 /.vscode
 /.settings
+/**/.settings
 .classpath
 .factorypath
 .project

src/main/java/org/gridsuite/geodata/server/GeoDataService.java

@@ -179,7 +179,7 @@ private void prepareGeoDataForComputation(Network network, Map<String, Substatio
                 if (geoDataForComputation.get(neighbourId) == null && !substationsToCalculate.contains(neighbourId)) {
                     substationsToCalculate.add(neighbourId);
                     Substation sub = network.getSubstation(neighbourId);
-                    if (sub != null) { // comes from a Request param string, could not exists in the network
+                    if (sub != null) { // neighbours comes from a Request param string, could not exists in the network
                         substations.add(sub);
                     } else {
                         LOGGER.debug("{} substation doesn't exist in the newtwork, will be ignored.", neighbourId);
@@ -288,7 +288,7 @@ private void step(Step step, Network network, Map<String, Set<String>> sortedNei
             for (Iterator<String> it = substationsToCalculate.iterator(); it.hasNext();) {
                 String substationId = it.next();
                 Set<String> neighbours = sortedNeighbours.get(substationId);
-                if (neighbours != null) {
+                if (neighbours != null) { // substationsToCalculate comes from a Request param string, could not exists in the network
                     double neighborhoodOffset = calculatedSubstationsOffset.get(neighbours) != null ? nextNeighborhoodOffset(calculatedSubstationsOffset.get(neighbours)) : 0;
 
                     // centroid calculation
@@ -545,7 +545,7 @@ public List<LineGeoData> getLinesByIds(Network network, Set<String> linesIds) {
 
         linesIds.forEach(id -> {
             Line line = network.getLine(id);
-            if (line != null) { // comes from a Request param string, could not exists in the network
+            if (line != null) { // linesIds comes from a Request param string, could not exists in the network
                 lines.add(line);
             } else {
                 LOGGER.debug("{} line doesn't exist in the newtwork, will be ignored.", id);