Skip to content

Commit 22fcc6b

Browse files
Add error message on group deletion if users are still referencing it (#93)
Signed-off-by: Franck LECUYER <[email protected]>
1 parent 1d4d1cf commit 22fcc6b

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

src/pages/groups/GroupsPage.tsx

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,18 @@ const GroupsPage: FunctionComponent = () => {
126126
const deleteGroups = useCallback((): Promise<void> | undefined => {
127127
let groupNames = rowsSelection.map((group) => group.name);
128128
return UserAdminSrv.deleteGroups(groupNames)
129-
.catch((error) =>
130-
snackError({
131-
messageTxt: error.message,
132-
headerId: 'groups.table.error.delete',
133-
})
134-
)
129+
.catch((error) => {
130+
if (error.status === 422) {
131+
snackError({
132+
headerId: 'groups.table.integrity.error.delete',
133+
});
134+
} else {
135+
snackError({
136+
messageTxt: error.message,
137+
headerId: 'groups.table.error.delete',
138+
});
139+
}
140+
})
135141
.then(() => gridContext?.refresh?.());
136142
}, [gridContext, rowsSelection, snackError]);
137143
const deleteGroupsDisabled = useMemo(() => rowsSelection.length <= 0, [rowsSelection.length]);

src/translations/en.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@
9494
"groups.table.users": "Users",
9595
"groups.table.users.description": "The group's users",
9696
"groups.table.error.delete": "Error while deleting group",
97+
"groups.table.integrity.error.delete": "Error while deleting group : a group is still referenced by users",
9798
"groups.table.error.add": "Error while adding group {group} : A group with the same name already exists.",
9899
"groups.table.toolbar.add.label": "Add a group",
99100
"groups.table.toolbar.add": "Add group",

src/translations/fr.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@
9595
"groups.table.users": "Utilisateurs",
9696
"groups.table.users.description": "Nom des utilisateurs associés au groupe",
9797
"groups.table.error.delete": "Erreur pendant la suppression du groupe",
98+
"groups.table.integrity.error.delete": "Erreur pendant la suppression du groupe : un groupe est toujours référencé par des utilisateurs",
9899
"groups.table.error.add": "Erreur pendant l'ajout du groupe {group} : Un groupe du même nom existe déjà.",
99100
"groups.table.error.update": "Erreur pendant la modification du groupe",
100101
"groups.table.toolbar.add.label": "Ajouter un groupe",

0 commit comments

Comments
 (0)