clean code and use simple click to edit profile

Signed-off-by: David BRAQUART <[email protected]>

Author: dbraquart

src/pages/groups/add-group-dialog.tsx

@@ -18,7 +18,7 @@ import {
 } from '@mui/material';
 import { FormattedMessage } from 'react-intl';
 import { Controller, useForm } from 'react-hook-form';
-import { ManageAccounts } from '@mui/icons-material';
+import { Groups } from '@mui/icons-material';
 import { GroupInfos, UserAdminSrv } from '../../services';
 import { useSnackMessage } from '@gridsuite/commons-ui';
 import { GridTableRef } from '../../components/Grid';
@@ -99,7 +99,7 @@ const AddGroupDialog: FunctionComponent<AddGroupDialogProps> = (props) => {
                             InputProps={{
                                 startAdornment: (
                                     <InputAdornment position="start">
-                                        <ManageAccounts />
+                                        <Groups />
                                     </InputAdornment>
                                 ),
                             }}

src/pages/profiles/modification/linked-path-display.tsx

@@ -30,14 +30,13 @@ const LinkedPathDisplay: FunctionComponent<LinkedPathDisplayProps> = (props) =>
                 id: props.nameKey,
             }) +
                 ' : ' +
-                (props.value
-                    ? props.value
-                    : intl.formatMessage({
-                          id:
-                              props.linkValidity === false
-                                  ? 'linked.path.display.invalidLink'
-                                  : 'linked.path.display.noLink',
-                      }))}
+                (props.value ??
+                    intl.formatMessage({
+                        id:
+                            props.linkValidity === false
+                                ? 'linked.path.display.invalidLink'
+                                : 'linked.path.display.noLink',
+                    }))}
         </Typography>
     );
 };

src/pages/profiles/modification/profile-modification-dialog.tsx

@@ -21,18 +21,10 @@ import yup from '../../../utils/yup-config';
 import { yupResolver } from '@hookform/resolvers/yup';
 import { useForm } from 'react-hook-form';
 import { FunctionComponent, useCallback, useEffect, useMemo, useState } from 'react';
-import { CustomMuiDialog, useSnackMessage } from '@gridsuite/commons-ui';
+import { CustomMuiDialog, FetchStatus, useSnackMessage } from '@gridsuite/commons-ui';
 import { UserAdminSrv, UserProfile } from '../../../services';
 import { UUID } from 'crypto';
 
-// TODO remove FetchStatus when exported in commons-ui (available soon)
-enum FetchStatus {
-    IDLE = 'IDLE',
-    FETCHING = 'FETCHING',
-    FETCH_SUCCESS = 'FETCH_SUCCESS',
-    FETCH_ERROR = 'FETCH_ERROR',
-}
-
 export interface ProfileModificationDialogProps {
     profileId: UUID | undefined;
     open: boolean;
@@ -47,7 +39,7 @@ const ProfileModificationDialog: FunctionComponent<ProfileModificationDialogProp
     onUpdate,
 }) => {
     const { snackError } = useSnackMessage();
-    const [dataFetchStatus, setDataFetchStatus] = useState<FetchStatus>(FetchStatus.IDLE);
+    const [dataFetchStatus, setDataFetchStatus] = useState<string>(FetchStatus.IDLE);
 
     const formSchema = yup
         .object()
@@ -115,27 +107,15 @@ const ProfileModificationDialog: FunctionComponent<ProfileModificationDialogProp
                     setDataFetchStatus(FetchStatus.FETCH_SUCCESS);
                     reset({
                         [PROFILE_NAME]: response.name,
-                        [LOADFLOW_PARAM_ID]: response.loadFlowParameterId ? response.loadFlowParameterId : undefined,
-                        [SECURITY_ANALYSIS_PARAM_ID]: response.securityAnalysisParameterId
-                            ? response.securityAnalysisParameterId
-                            : undefined,
-                        [SENSITIVITY_ANALYSIS_PARAM_ID]: response.sensitivityAnalysisParameterId
-                            ? response.sensitivityAnalysisParameterId
-                            : undefined,
-                        [SHORTCIRCUIT_PARAM_ID]: response.shortcircuitParameterId
-                            ? response.shortcircuitParameterId
-                            : undefined,
-                        [VOLTAGE_INIT_PARAM_ID]: response.voltageInitParameterId
-                            ? response.voltageInitParameterId
-                            : undefined,
+                        [LOADFLOW_PARAM_ID]: response.loadFlowParameterId ?? undefined,
+                        [SECURITY_ANALYSIS_PARAM_ID]: response.securityAnalysisParameterId ?? undefined,
+                        [SENSITIVITY_ANALYSIS_PARAM_ID]: response.sensitivityAnalysisParameterId ?? undefined,
+                        [SHORTCIRCUIT_PARAM_ID]: response.shortcircuitParameterId ?? undefined,
+                        [VOLTAGE_INIT_PARAM_ID]: response.voltageInitParameterId ?? undefined,
                         [USER_QUOTA_CASE_NB]: response.maxAllowedCases,
                         [USER_QUOTA_BUILD_NB]: response.maxAllowedBuilds,
-                        [SPREADSHEET_CONFIG_COLLECTION_ID]: response.spreadsheetConfigCollectionId
-                            ? response.spreadsheetConfigCollectionId
-                            : undefined,
-                        [NETWORK_VISUALIZATION_PARAMETERS_ID]: response.networkVisualizationParameterId
-                            ? response.networkVisualizationParameterId
-                            : undefined,
+                        [SPREADSHEET_CONFIG_COLLECTION_ID]: response.spreadsheetConfigCollectionId ?? undefined,
+                        [NETWORK_VISUALIZATION_PARAMETERS_ID]: response.networkVisualizationParameterId ?? undefined,
                     });
                 })
                 .catch((error) => {

src/pages/profiles/profiles-page.tsx

@@ -9,7 +9,7 @@ import { FunctionComponent, useCallback, useRef, useState } from 'react';
 import { Grid } from '@mui/material';
 import { GridTableRef } from '../../components/Grid';
 import { UserProfile } from '../../services';
-import { RowDoubleClickedEvent } from 'ag-grid-community';
+import { RowClickedEvent } from 'ag-grid-community';
 import ProfileModificationDialog from './modification/profile-modification-dialog';
 import { UUID } from 'crypto';
 import ProfilesTable from './profiles-table';
@@ -33,7 +33,7 @@ const ProfilesPage: FunctionComponent = () => {
         handleCloseProfileModificationDialog();
     }, [gridContext, handleCloseProfileModificationDialog]);
 
-    const onRowDoubleClicked = useCallback((event: RowDoubleClickedEvent<UserProfile>) => {
+    const onRowClicked = useCallback((event: RowClickedEvent<UserProfile>) => {
         if (event.data) {
             setEditingProfileId(event.data.id);
             setOpenProfileModificationDialog(true);
@@ -51,7 +51,7 @@ const ProfilesPage: FunctionComponent = () => {
                 />
                 <ProfilesTable
                     gridRef={gridRef}
-                    onRowDoubleClicked={onRowDoubleClicked}
+                    onRowClicked={onRowClicked}
                     setOpenAddProfileDialog={setOpenAddProfileDialog}
                 />
                 <AddProfileDialog gridRef={gridRef} open={openAddProfileDialog} setOpen={setOpenAddProfileDialog} />

src/pages/profiles/profiles-table.tsx

@@ -10,13 +10,7 @@ import { useIntl } from 'react-intl';
 import { Cancel, CheckCircle, ManageAccounts, RadioButtonUnchecked } from '@mui/icons-material';
 import { GridButton, GridButtonDelete, GridTable, GridTableRef } from '../../components/Grid';
 import { UserAdminSrv, UserProfile } from '../../services';
-import {
-    ColDef,
-    GetRowIdParams,
-    RowDoubleClickedEvent,
-    SelectionChangedEvent,
-    TextFilterParams,
-} from 'ag-grid-community';
+import { ColDef, GetRowIdParams, RowClickedEvent, SelectionChangedEvent, TextFilterParams } from 'ag-grid-community';
 import { useSnackMessage } from '@gridsuite/commons-ui';
 import DeleteConfirmationDialog from '../common/delete-confirmation-dialog';
 
@@ -31,7 +25,7 @@ const defaultColDef: ColDef<UserProfile> = {
 
 export interface ProfilesTableProps {
     gridRef: RefObject<GridTableRef<UserProfile>>;
-    onRowDoubleClicked: (event: RowDoubleClickedEvent<UserProfile>) => void;
+    onRowClicked: (event: RowClickedEvent<UserProfile>) => void;
     setOpenAddProfileDialog: (open: boolean) => void;
 }
 
@@ -43,7 +37,7 @@ const ProfilesTable: FunctionComponent<ProfilesTableProps> = (props) => {
     const [showDeletionDialog, setShowDeletionDialog] = useState(false);
 
     function getRowId(params: GetRowIdParams<UserProfile>): string {
-        return params.data.id ? params.data.id : '';
+        return params.data.id ?? '';
     }
 
     const onSelectionChanged = useCallback(
@@ -139,7 +133,7 @@ const ProfilesTable: FunctionComponent<ProfilesTableProps> = (props) => {
                     headerCheckbox: true,
                     hideDisabledCheckboxes: false,
                 }}
-                onRowDoubleClicked={props.onRowDoubleClicked}
+                onRowClicked={props.onRowClicked}
                 onSelectionChanged={onSelectionChanged}
             >
                 <GridButton