clean code

Signed-off-by: David BRAQUART <[email protected]>

Author: dbraquart

src/pages/common/table-config.ts

@@ -11,7 +11,6 @@ export const defaultColDef: ColDef = {
     editable: false,
     resizable: true,
     minWidth: 50,
-    cellRenderer: 'agAnimateSlideCellRenderer',
     rowDrag: false,
     sortable: true,
 };

src/pages/common/table-selection.tsx

@@ -14,7 +14,7 @@ import { ColDef, GetRowIdParams, GridReadyEvent } from 'ag-grid-community';
 import { defaultColDef, defaultRowSelection } from './table-config';
 
 export interface TableSelectionProps {
-    itemNameTranslationKey: string;
+    itemName: string;
     tableItems: string[];
     tableSelectedItems?: string[];
     onSelectionChanged: (selectedItems: string[]) => void;
@@ -45,8 +45,8 @@ const TableSelection: FunctionComponent<TableSelectionProps> = (props) => {
                 field: 'id',
                 filter: true,
                 sortable: true,
-                minWidth: 80,
                 tooltipField: 'id',
+                flex: 1,
             },
         ],
         []
@@ -71,7 +71,7 @@ const TableSelection: FunctionComponent<TableSelectionProps> = (props) => {
         <Grid item container direction={'column'} style={{ height: '100%' }}>
             <Grid item>
                 <Typography variant="subtitle1">
-                    <FormattedMessage id={props.itemNameTranslationKey}></FormattedMessage>
+                    <FormattedMessage id={props.itemName}></FormattedMessage>
                     {` (${selectedRowsLength} / ${rowData?.length ?? 0})`}
                 </Typography>
             </Grid>

src/pages/groups/groups-table.tsx

@@ -16,7 +16,7 @@ import {
     ITooltipParams,
     RowClickedEvent,
     SelectionChangedEvent,
-    TextFilterParams
+    TextFilterParams,
 } from 'ag-grid-community';
 import { useSnackMessage } from '@gridsuite/commons-ui';
 import DeleteConfirmationDialog from '../common/delete-confirmation-dialog';

src/pages/groups/modification/group-modification-form.tsx

@@ -40,9 +40,9 @@ const GroupModificationForm: FunctionComponent<GroupModificationFormProps> = ({
             <Grid item xs={12}>
                 <TextInput name={GROUP_NAME} label={'groups.table.id'} clearable={true} />
             </Grid>
-            <Grid item xs={12} style={{ height: '85%' }}>
+            <Grid item xs={12} style={{ height: '90%' }}>
                 <TableSelection
-                    itemNameTranslationKey={'groups.table.users'}
+                    itemName={'groups.table.users'}
                     tableItems={usersOptions}
                     tableSelectedItems={selectedUsers}
                     onSelectionChanged={onSelectionChanged}

src/pages/profiles/profiles-page.tsx

@@ -41,22 +41,24 @@ const ProfilesPage: FunctionComponent = () => {
     }, []);
 
     return (
-        <Grid item container direction="column" spacing={2} component="section">
-            <Grid item container xs sx={{ width: 1 }}>
-                <ProfilesTable
-                    gridRef={gridRef}
-                    onRowClicked={onRowClicked}
-                    setOpenAddProfileDialog={setOpenAddProfileDialog}
-                />
-                <AddProfileDialog gridRef={gridRef} open={openAddProfileDialog} setOpen={setOpenAddProfileDialog} />
-                <ProfileModificationDialog
-                    profileId={editingProfileId}
-                    open={openProfileModificationDialog}
-                    onClose={handleCloseProfileModificationDialog}
-                    onUpdate={handleUpdateProfileModificationDialog}
-                />
+        <>
+            <Grid item container direction="column" spacing={2} component="section">
+                <Grid item container xs sx={{ width: 1 }}>
+                    <ProfilesTable
+                        gridRef={gridRef}
+                        onRowClicked={onRowClicked}
+                        setOpenAddProfileDialog={setOpenAddProfileDialog}
+                    />
+                </Grid>
             </Grid>
-        </Grid>
+            <AddProfileDialog gridRef={gridRef} open={openAddProfileDialog} setOpen={setOpenAddProfileDialog} />
+            <ProfileModificationDialog
+                profileId={editingProfileId}
+                open={openProfileModificationDialog}
+                onClose={handleCloseProfileModificationDialog}
+                onUpdate={handleUpdateProfileModificationDialog}
+            />
+        </>
     );
 };
 export default ProfilesPage;

src/pages/users/modification/user-modification-dialog.tsx

@@ -110,8 +110,8 @@ const UserModificationDialog: FunctionComponent<UserModificationDialogProps> = (
         (userFormData: UserModificationFormType) => {
             if (userInfos) {
                 const newData: UpdateUserInfos = {
-                    sub: userInfos.sub, // sub cannot be changed, it is a PK in database
-                    isAdmin: userInfos.isAdmin, // cannot be changed for now
+                    sub: userInfos.sub, // can't be changed
+                    isAdmin: userInfos.isAdmin, // can't be changed
                     profileName: userFormData.profileName ?? undefined,
                     groups: selectedGroups,
                 };

src/pages/users/modification/user-modification-form.tsx

@@ -63,7 +63,7 @@ const UserModificationForm: FunctionComponent<UserModificationFormProps> = ({
             </Grid>
             <Grid item xs={12} style={{ height: '85%' }}>
                 <TableSelection
-                    itemNameTranslationKey={'users.table.groups'}
+                    itemName={'users.table.groups'}
                     tableItems={groupOptions}
                     tableSelectedItems={selectedGroups}
                     onSelectionChanged={onSelectionChanged}