Skip to content

Commit f7a5a83

Browse files
authored
Fix user permissions on elements (#565)
* fix(useDirectoryContent): populate ownerLabel and lastModifiedByLabel instead of owner existing attribute which is used to compute user permissions on elements * update commons-ui version to 0.71.1 Signed-off-by: sBouzols <[email protected]>
1 parent ce0e79a commit f7a5a83

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"dependencies": {
88
"@emotion/react": "^11.11.4",
99
"@emotion/styled": "^11.11.5",
10-
"@gridsuite/commons-ui": "0.71.0",
10+
"@gridsuite/commons-ui": "0.71.1",
1111
"@hookform/resolvers": "^3.3.4",
1212
"@mui/icons-material": "^5.15.14",
1313
"@mui/lab": "5.0.0-alpha.169",

src/components/utils/directory-content-utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ export const getColumnsDefinition = (childrenMetadata: Record<UUID, ElementAttri
122122
headerName: intl.formatMessage({
123123
id: 'creator',
124124
}),
125-
field: 'owner',
125+
field: 'ownerLabel',
126126
cellRenderer: UserCellRenderer,
127127
minWidth: 110,
128128
flex: 1,
@@ -140,7 +140,7 @@ export const getColumnsDefinition = (childrenMetadata: Record<UUID, ElementAttri
140140
headerName: intl.formatMessage({
141141
id: 'modifiedBy',
142142
}),
143-
field: 'lastModifiedBy',
143+
field: 'lastModifiedByLabel',
144144
cellRenderer: UserCellRenderer,
145145
minWidth: 110,
146146
flex: 1,

src/hooks/useDirectoryContent.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ export const useDirectoryContent = () => {
8585
// discarding request for older directory
8686
if (previousData.current === currentChildren) {
8787
res[1].forEach((e) => {
88-
e.owner = getName(e.owner, res[0].data);
89-
e.lastModifiedBy = getName(e.lastModifiedBy, res[0].data);
88+
e.ownerLabel = getName(e.owner, res[0].data);
89+
e.lastModifiedByLabel = getName(e.lastModifiedBy, res[0].data);
9090
metadata[e.elementUuid] = e;
9191
});
9292
setChildrenMetadata(metadata);
@@ -107,8 +107,8 @@ export const useDirectoryContent = () => {
107107
}
108108
return currentChildren.map((x) => ({
109109
...x,
110-
owner: childrenMetadata?.[x.elementUuid]?.owner,
111-
lastModifiedBy: childrenMetadata?.[x.elementUuid]?.lastModifiedBy,
110+
ownerLabel: childrenMetadata?.[x.elementUuid]?.ownerLabel,
111+
lastModifiedLabel: childrenMetadata?.[x.elementUuid]?.lastModifiedByLabel,
112112
}));
113113
}, [currentChildren, childrenMetadata]);
114114

src/utils/rest-api.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ export function updateElement(elementUuid: UUID, element: unknown) {
268268
});
269269
}
270270

271-
export function insertDirectory(directoryName: string, parentUuid: UUID, owner: string) {
271+
export function insertDirectory(directoryName: string, parentUuid: UUID, ownerId: string) {
272272
console.info("Inserting a new folder '%s'", directoryName);
273273
const insertDirectoryUrl = `${PREFIX_DIRECTORY_SERVER_QUERIES}/v1/directories/${parentUuid}/elements`;
274274
return backendFetchJson(insertDirectoryUrl, {
@@ -281,12 +281,12 @@ export function insertDirectory(directoryName: string, parentUuid: UUID, owner:
281281
elementUuid: null,
282282
elementName: directoryName,
283283
type: 'DIRECTORY',
284-
owner,
284+
ownerId,
285285
}),
286286
});
287287
}
288288

289-
export function insertRootDirectory(directoryName: string, owner: string) {
289+
export function insertRootDirectory(directoryName: string, ownerId: string) {
290290
console.info("Inserting a new root folder '%s'", directoryName);
291291
const insertRootDirectoryUrl = `${PREFIX_DIRECTORY_SERVER_QUERIES}/v1/root-directories`;
292292
return backendFetchJson(insertRootDirectoryUrl, {
@@ -297,7 +297,7 @@ export function insertRootDirectory(directoryName: string, owner: string) {
297297
},
298298
body: JSON.stringify({
299299
elementName: directoryName,
300-
owner,
300+
ownerId,
301301
}),
302302
});
303303
}

0 commit comments

Comments
 (0)