Disable spreadsheet csv and filter exports when no data available (#3290)

Signed-off-by: David BRAQUART <[email protected]>

Author: dbraquart

src/components/spreadsheet-view/spreadsheet/spreadsheet-toolbar/row-counter/use-filtered-row-counter.tsx

@@ -26,6 +26,7 @@ export type UseFilteredRowCounterInfoReturn = {
     rowCountLabel: string | undefined;
     tooltipContent: ReactElement | undefined;
     registerRowCounterEvents: (params: RowDataUpdatedEvent) => void;
+    displayedRows: number | null;
 };
 
 export function useFilteredRowCounterInfo({
@@ -101,8 +102,8 @@ export function useFilteredRowCounterInfo({
         if (displayedRows === 0 && isAnyFilterPresent) {
             return intl.formatMessage({ id: 'NoMatch' });
         } else {
-            const plural = `${intl.formatMessage({ id: 'Rows' })}${totalRows === 1 ? '' : 's'}`;
-            return displayedRows !== totalRows ? `${displayedRows} / ${totalRows} ${plural}` : `${totalRows} ${plural}`;
+            const plural = intl.formatMessage({ id: 'Rows' }, { count: totalRows });
+            return displayedRows === totalRows ? `${totalRows} ${plural}` : `${displayedRows} / ${totalRows} ${plural}`;
         }
     }, [displayedRows, totalRows, intl, isAnyFilterPresent]);
 
@@ -119,16 +120,15 @@ export function useFilteredRowCounterInfo({
         const lines: string[] = [`${intl.formatMessage({ id: 'ClickToReset' })}`];
         if (Object.keys(gsFilterByType)?.length > 0) {
             lines.push(`${intl.formatMessage({ id: 'ExternalFilters' })} : `);
-
-            Object.entries(gsFilterByType).forEach(([filterType, labels]) => {
+            for (const [filterType, labels] of Object.entries(gsFilterByType)) {
                 const formattedLabels = labels.map((label) => intl.formatMessage({ id: label })).join(', ');
                 lines.push(`- ${intl.formatMessage({ id: filterType })} : "${formattedLabels}"`);
-            });
+            }
         }
 
         if (spreadsheetColumnsFiltersState?.length > 0) {
             lines.push(`${intl.formatMessage({ id: 'ColumnsFilters' })} : `);
-            spreadsheetColumnsFiltersState.forEach((filterModel) => {
+            for (const filterModel of spreadsheetColumnsFiltersState) {
                 const headerName =
                     gridRef.current?.api.getColumn(filterModel.column)?.getColDef()?.headerName ?? filterModel.column;
                 lines.push(
@@ -137,7 +137,7 @@ export function useFilteredRowCounterInfo({
                         ', '
                     )
                 );
-            });
+            }
         }
         return <span style={{ whiteSpace: 'pre-line' }}>{lines.join('\n')}</span>;
     }, [globalFilterSpreadsheetState, gridRef, intl, isAnyFilterPresent, isLoading, spreadsheetColumnsFiltersState]);
@@ -158,5 +158,6 @@ export function useFilteredRowCounterInfo({
         rowCountLabel,
         tooltipContent,
         registerRowCounterEvents,
+        displayedRows,
     };
 }

src/components/spreadsheet-view/spreadsheet/spreadsheet-toolbar/save/save-spreadsheet-button.tsx

@@ -39,7 +39,7 @@ interface SaveSpreadsheetButtonProps {
     columns: ColDef[];
     disabled: boolean;
     tableDefinition: SpreadsheetTabDefinition;
-    dataSize?: number;
+    dataSize: number;
     nodeAliases: NodeAlias[] | undefined;
 }
 

src/components/spreadsheet-view/spreadsheet/spreadsheet-toolbar/spreadsheet-toolbar.tsx

@@ -76,6 +76,7 @@ export const SpreadsheetToolbar = ({
                     columns={columns}
                     disabled={disabled}
                     nodeAliases={nodeAliases}
+                    dataSize={rowCounterInfos.displayedRows ?? 0}
                 />
             </Grid>
         </Grid>

src/translations/en.json

@@ -1572,7 +1572,7 @@
     "DiagramLayoutStoreSuccess": "Diagrams successfully stored",
     "MaxNumberOfNadDiagramsReached": "You need to close at least one network area diagram to open a new one",
     "NoMatch": "No match",
-    "Rows": "row",
+    "Rows": "{count, plural,=1 {row} other {rows}}",
     "ExternalFilters": "External filters",
     "ColumnsFilters": "Columns filters",
     "genericFilter": "Generic",

src/translations/fr.json

@@ -1568,7 +1568,7 @@
     "DiagramLayoutStoreSuccess": "Images mémorisées avec succès",
     "MaxNumberOfNadDiagramsReached": "Vous devez fermer au moins une image nodale existante pour en ouvrir une nouvelle",
     "NoMatch": "Pas de correspondance",
-    "Rows": "ligne",
+    "Rows": "{count, plural,=1 {ligne} other {lignes}}",
     "ExternalFilters": "Filtres externes",
     "ColumnsFilters": "Filtres de colonnes",
     "genericFilter": "Générique",