show coherent state for limit sets When applicability is changed (#3392)

Signed-off-by: basseche <[email protected]>

Author: basseche

src/components/dialogs/limits/limits-pane-utils.ts

@@ -287,6 +287,11 @@ export const combineFormAndMapServerLimitsGroups = (
     return updatedOpLG;
 };
 
+export const getOpLimitsGroupInfosFromBranchModification = (
+    formBranchModification: LineModificationFormInfos
+): OperationalLimitsGroupFormInfos[] => {
+    return formBranchModification?.limits?.operationalLimitsGroups ?? [];
+};
 export const addModificationTypeToTemporaryLimits = (
     formTemporaryLimits: TemporaryLimitFormInfos[]
 ): TemporaryLimit[] => {

src/components/dialogs/limits/limits-pane.tsx

@@ -71,6 +71,17 @@ export function LimitsPane({
         return null;
     };
 
+    const getCurrentLimitsIgnoreApplicability = (
+        equipmentToModify: any,
+        operationalLimitsGroupName: string
+    ): CurrentLimits | null => {
+        if (equipmentToModify?.currentLimits) {
+            return equipmentToModify.currentLimits.find(
+                (currentLimit: CurrentLimits) => currentLimit.id === operationalLimitsGroupName
+            );
+        }
+        return null;
+    };
     /**
      * returns an error message id if :
      * - there are more than 2 limit sets with the same name
@@ -202,7 +213,11 @@ export function LimitsPane({
                                         clearableFields={clearableFields}
                                         permanentCurrentLimitPreviousValue={
                                             getCurrentLimits(equipmentToModify, operationalLimitsGroup.id)
-                                                ?.permanentLimit
+                                                ?.permanentLimit ??
+                                            getCurrentLimitsIgnoreApplicability(
+                                                equipmentToModify,
+                                                operationalLimitsGroup.name
+                                            )?.permanentLimit
                                         }
                                         temporaryLimitsPreviousValues={
                                             getCurrentLimits(equipmentToModify, operationalLimitsGroup.id)

src/components/dialogs/network-modifications/line/modification/line-modification-dialog.tsx

@@ -62,6 +62,7 @@ import {
     getAllLimitsFormData,
     getLimitsEmptyFormData,
     getLimitsValidationSchema,
+    getOpLimitsGroupInfosFromBranchModification,
 } from '../../../limits/limits-pane-utils';
 import {
     getCharacteristicsEmptyFormData,
@@ -317,10 +318,9 @@ const LineModificationDialog = ({
                                     ...{
                                         [LIMITS]: {
                                             [ENABLE_OLG_MODIFICATION]: formValues.limits[ENABLE_OLG_MODIFICATION],
-                                            [OPERATIONAL_LIMITS_GROUPS]: combineFormAndMapServerLimitsGroups(
-                                                formValues,
-                                                line
-                                            ),
+                                            [OPERATIONAL_LIMITS_GROUPS]: formValues.limits[ENABLE_OLG_MODIFICATION]
+                                                ? getOpLimitsGroupInfosFromBranchModification(formValues)
+                                                : combineFormAndMapServerLimitsGroups(formValues, line),
                                         },
                                     },
                                     [ADDITIONAL_PROPERTIES]: getConcatenatedProperties(line, getValues),

src/components/dialogs/network-modifications/two-windings-transformer/modification/two-windings-transformer-modification-dialog.jsx

@@ -91,11 +91,12 @@ import {
 import {
     addModificationTypeToOpLimitsGroups,
     addOperationTypeToSelectedOpLG,
+    combineFormAndMapServerLimitsGroups,
     formatOpLimitGroupsToFormInfos,
     getAllLimitsFormData,
     getLimitsEmptyFormData,
     getLimitsValidationSchema,
-    combineFormAndMapServerLimitsGroups,
+    getOpLimitsGroupInfosFromBranchModification,
 } from '../../../limits/limits-pane-utils';
 import { useOpenShortWaitFetching } from 'components/dialogs/commons/handle-modification-form';
 import TwoWindingsTransformerModificationDialogHeader from './two-windings-transformer-modification-dialog-header';
@@ -659,10 +660,9 @@ const TwoWindingsTransformerModificationDialog = ({
                                     ...{
                                         [LIMITS]: {
                                             [ENABLE_OLG_MODIFICATION]: formValues.limits[ENABLE_OLG_MODIFICATION],
-                                            [OPERATIONAL_LIMITS_GROUPS]: combineFormAndMapServerLimitsGroups(
-                                                formValues,
-                                                twt
-                                            ),
+                                            [OPERATIONAL_LIMITS_GROUPS]: formValues.limits[ENABLE_OLG_MODIFICATION]
+                                                ? getOpLimitsGroupInfosFromBranchModification(formValues)
+                                                : combineFormAndMapServerLimitsGroups(formValues, twt),
                                         },
                                     },
                                     ...getRatioTapChangerFormData({