chore: fix sonar issues

Signed-off-by: Joris Mancini <[email protected]>

Author: TheMaskedTurtle

src/components/spreadsheet-view/hooks/use-built-nodes-ids.ts

@@ -8,7 +8,7 @@
 import { useSelector } from 'react-redux';
 import type { AppState } from '../../../redux/reducer';
 import { useStableComputedSet } from '../../../hooks/use-stable-computed-set';
-import type { UUID } from 'crypto';
+import type { UUID } from 'node:crypto';
 import { validAlias } from './use-node-aliases';
 import { NodeType } from '../../graph/tree-node.type';
 import { isStatusBuilt } from '../../graph/util/model-functions';
@@ -27,15 +27,15 @@ export function useBuiltNodesIds(nodeAliases: NodeAlias[] | undefined) {
         }
 
         const ids = new Set<UUID>();
-        if (aliasedNodesIds && aliasedNodesIds.length > 0) {
-            treeNodes?.forEach((treeNode) => {
+        if (aliasedNodesIds && aliasedNodesIds.length > 0 && treeNodes) {
+            for (const treeNode of treeNodes) {
                 if (
                     aliasedNodesIds.includes(treeNode.id) &&
                     (treeNode.type === NodeType.ROOT || isStatusBuilt(treeNode.data.globalBuildStatus))
                 ) {
                     ids.add(treeNode.id);
                 }
-            });
+            }
         }
         return ids;
     }, [nodeAliases, treeNodes]);

src/components/spreadsheet-view/hooks/use-update-equipments-on-notification.ts

@@ -6,7 +6,7 @@
  */
 
 import { useCallback } from 'react';
-import type { UUID } from 'crypto';
+import type { UUID } from 'node:crypto';
 import { DeletedEquipment, isStudyNotification, type NetworkImpactsInfos } from '../../../types/notification-types';
 import { isSpreadsheetEquipmentType, SpreadsheetEquipmentType } from '../types/spreadsheet.type';
 import {

src/components/spreadsheet-view/spreadsheet/spreadsheet-content/hooks/use-spreadsheet-equipments.ts

@@ -50,7 +50,9 @@ export const useSpreadsheetEquipments = (
 
     const nodesIdsToRemove = useStableComputedSet(() => {
         const unwantedFetchedNodes = new Set(loadedNodesIdsForType);
-        builtNodesIds.forEach((nodeId) => unwantedFetchedNodes.delete(nodeId));
+        for (const nodeId of builtNodesIds) {
+            unwantedFetchedNodes.delete(nodeId);
+        }
         return unwantedFetchedNodes;
     }, [builtNodesIds]);
 
@@ -59,7 +61,9 @@ export const useSpreadsheetEquipments = (
             return builtNodesIds;
         }
         const nodesIdToFetch = new Set<UUID>(builtNodesIds);
-        loadedNodesIdsForType.forEach((nodeId) => nodesIdToFetch.delete(nodeId));
+        for (const nodeId of loadedNodesIdsForType) {
+            nodesIdToFetch.delete(nodeId);
+        }
         return nodesIdToFetch;
     }, [currentNode?.id, loadedNodesIdsForType, nodeAliases, treeNodes]);