Limit spreadsheet node aliases to 5 (#3075)

Signed-off-by: David BRAQUART <[email protected]>

Author: dbraquart

src/components/spreadsheet-view/spreadsheet/spreadsheet-toolbar/nodes-config/node-config-table.tsx

@@ -13,7 +13,7 @@ import { useFieldArray } from 'react-hook-form';
 import { useIntl } from 'react-intl';
 import { AppState } from '../../../../../redux/reducer';
 import { CurrentTreeNode } from '../../../../graph/tree-node.type';
-import { NODE_ALIAS, NODE_NAME, NODES_ALIASES } from './nodes-config-dialog.utils';
+import { NODE_ALIAS, NODE_NAME, NODES_ALIASES, NODES_ALIASES_MAX_NUMBER } from './nodes-config-dialog.utils';
 
 const NodeConfigTable = () => {
     const treeModel = useSelector((state: AppState) => state.networkModificationTreeModel);
@@ -75,6 +75,7 @@ const NodeConfigTable = () => {
             withAddRowsDialog={false}
             disableDragAndDrop={true}
             showMoveArrow={false}
+            maxRows={NODES_ALIASES_MAX_NUMBER}
         />
     );
 };

src/components/spreadsheet-view/spreadsheet/spreadsheet-toolbar/nodes-config/nodes-config-dialog.utils.ts

@@ -11,6 +11,7 @@ import { areArrayElementsUnique } from '../../../../utils/utils';
 export const NODE_ALIAS = 'alias';
 export const NODE_NAME = 'name';
 export const NODES_ALIASES = 'nodesAliases';
+export const NODES_ALIASES_MAX_NUMBER = 5;
 
 export const initialNodesForm: NodesForm = {
     [NODES_ALIASES]: [],
@@ -45,6 +46,10 @@ export const nodesFormSchema = yup.object().shape({
         .test('uniqueNodeNames', 'spreadsheet/parameter_aliases/unique_node_names', (array) => {
             const nodeNamesArray = array.map((l) => l[NODE_NAME]).filter((value) => value);
             return areArrayElementsUnique(nodeNamesArray);
+        })
+        // error message must be in-sync with NODES_ALIASES_MAX_NUMBER and MaximumRowNumberError from commons-ui
+        .test('maxNodeNames', 'spreadsheet/parameter_aliases/maximum_row_number_error', (array) => {
+            return array.length <= NODES_ALIASES_MAX_NUMBER;
         }),
 });
 

src/translations/spreadsheet-en.ts

@@ -108,6 +108,7 @@ const spreadsheetEn = {
     'spreadsheet/parameter_aliases/node_doesnt_exist': 'No node with this name',
     'spreadsheet/parameter_aliases/unique_aliases': 'Aliases should be unique',
     'spreadsheet/parameter_aliases/unique_node_names': 'Each node can only have one alias',
+    'spreadsheet/parameter_aliases/maximum_row_number_error': 'The number of rows must not exceed the value 5',
     'spreadsheet/filter/config': 'Gridsuite filters',
     'spreadsheet/remove_spreadsheet_confirmation':
         'Are you sure you want to remove the spreadsheet "{spreadsheetName}"?',

src/translations/spreadsheet-fr.ts

@@ -113,6 +113,7 @@ const spreadsheetFr = {
     'spreadsheet/parameter_aliases/node_doesnt_exist': 'Aucun nœud avec ce nom',
     'spreadsheet/parameter_aliases/unique_aliases': 'Les alias doivent être unique',
     'spreadsheet/parameter_aliases/unique_node_names': 'Chaque nœud ne peut avoir qu’un seul alias',
+    'spreadsheet/parameter_aliases/maximum_row_number_error': 'Le nombre de lignes ne doit pas dépasser la valeur 5',
     'spreadsheet/filter/config': 'Filtres Gridsuite',
     'spreadsheet/remove_spreadsheet_confirmation': 'Êtes-vous sûr de vouloir supprimer le tableur {spreadsheetName} ?',
     'spreadsheet/remove_spreadsheet_error': 'Erreur lors de la suppression du tableur',