add some check value (#2456)

Signed-off-by: Rehili Ghazwa <[email protected]>

Author: ghazwarhili

src/components/dialogs/network-modifications/hvdc-line/lcc/creation/lcc-converter-station.tsx

@@ -59,7 +59,12 @@ export const getLccConverterStationSchema = () =>
             .min(0, 'NormalizedPercentage')
             .max(100, 'NormalizedPercentage')
             .required(),
-        [POWER_FACTOR]: yup.number().nullable().max(1, 'powerFactorNormalizedPercentage').required(),
+        [POWER_FACTOR]: yup
+            .number()
+            .nullable()
+            .min(-1, 'powerFactorMinValueError')
+            .max(1, 'powerFactorMaxValueError')
+            .required(),
         [FILTERS_SHUNT_COMPENSATOR_TABLE]: yup
             .array()
             .of(

src/components/dialogs/network-modifications/hvdc-line/lcc/creation/lcc-hvdc-line.tsx

@@ -26,11 +26,16 @@ export const getLccHvdcLineSchema = () =>
     yup
         .object()
         .shape({
-            [NOMINAL_V]: yup.number().nullable().required(),
-            [R]: yup.number().nullable().required(),
-            [MAX_P]: yup.number().nullable().required(),
+            [NOMINAL_V]: yup.number().nullable().min(0, 'nominalVMustBeGreaterOrEqualToZero').required(),
+            [R]: yup.number().nullable().min(0, 'dcResistanceMustBeGreaterOrEqualToZero').required(),
+            [MAX_P]: yup.number().nullable().min(0, 'maxPMustBeGreaterOrEqualToZero').required(),
+            [ACTIVE_POWER_SETPOINT]: yup
+                .number()
+                .nullable()
+                .min(0, 'activePowerSetpointMinValueError')
+                .max(yup.ref(MAX_P), 'activePowerSetpointMaxValueError')
+                .required(),
             [CONVERTERS_MODE]: yup.string().required(),
-            [ACTIVE_POWER_SETPOINT]: yup.number().nullable().required(),
         })
         .concat(creationPropertiesSchema);
 

src/translations/en.json

@@ -914,7 +914,13 @@
     "PermanentCurrentLimitText": "Permanent current limit",
     "permanentCurrentLimitMustBeGreaterThanZero": "The permanent current limit value must be greater than 0",
     "qMaxAtNominalVMustBeGreaterThanZero": "The Qmax available at nominal voltage value must be greater than 0",
-    "powerFactorNormalizedPercentage": "The power factor value must be less than 1",
+    "powerFactorMaxValueError": "The power factor value must be less than 1",
+    "powerFactorMinValueError": "The power factor value must be greater than -1",
+    "nominalVMustBeGreaterOrEqualToZero": "The DC nominal voltage value must be greater than 0",
+    "dcResistanceMustBeGreaterOrEqualToZero": "The DC resistance value must be greater than 0",
+    "maxPMustBeGreaterOrEqualToZero": "The maximum active power value must be greater than 0",
+    "activePowerSetpointMinValueError": "The active power value must be greater than 0",
+    "activePowerSetpointMaxValueError": "The active power value must be less than the maximum active power value",
     "PermanentCurrentLimitText1": "Permanent current limit 1",
     "PermanentCurrentLimitText2": "Permanent current limit 2",
 

src/translations/fr.json

@@ -911,7 +911,13 @@
     "PermanentCurrentLimitText": "IST",
     "permanentCurrentLimitMustBeGreaterThanZero": "La valeur IST doit être supérieure à 0",
     "qMaxAtNominalVMustBeGreaterThanZero": "La valeur Q installée à tension nominale doit être supérieure à 0",
-    "powerFactorNormalizedPercentage": "La valeur de Coefficient Q/P doit être inférieur à 1",
+    "powerFactorMaxValueError": "La valeur du coefficient Q/P doit être inférieure à 1",
+    "powerFactorMinValueError": "La valeur du coefficient Q/P doit être supérieure à -1",
+    "nominalVMustBeGreaterOrEqualToZero": "La valeur de la tension nominale DC doit être supérieure à 0",
+    "dcResistanceMustBeGreaterOrEqualToZero": "La valeur de la résistance DC doit être supérieure à 0",
+    "maxPMustBeGreaterOrEqualToZero": "La valeur de la puissance active max doit être supérieure à 0",
+    "activePowerSetpointMinValueError": "La valeur de la puissance active doit être supérieure à 0",
+    "activePowerSetpointMaxValueError": "La valeur de la puissance active doit être inférieure à la valeur de la puissance active max",
     "PermanentCurrentLimitText1": "IST 1",
     "PermanentCurrentLimitText2": "IST 2",