Skip to content

Commit a0fbbcb

Browse files
authored
[FIX] Missing debug mode when showing confirmation with params unsaved (#3281)
--------- Signed-off-by: Thang PHAM <[email protected]>
1 parent 0da74ae commit a0fbbcb

File tree

1 file changed

+16
-9
lines changed

1 file changed

+16
-9
lines changed

src/components/run-button.jsx

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ const RunButton = ({ runnables, activeRunnables, getStatus, computationStopped,
2121
const isDirtyComputationParameters = useSelector((state) => state.isDirtyComputationParameters);
2222
const [isLaunchingPopupOpen, setIsLaunchingPopupOpen] = useState(false);
2323

24+
// a transient state which is used only for a run with popup dialog
25+
const [runWithDebug, setRunWithDebug] = useState(false);
26+
2427
const runnablesText = useMemo(
2528
() => Object.fromEntries(activeRunnables.map((k) => [k, intl.formatMessage({ id: runnables[k].messageId })])),
2629
[intl, runnables, activeRunnables]
@@ -81,22 +84,26 @@ const RunButton = ({ runnables, activeRunnables, getStatus, computationStopped,
8184
return getRunningStatus() === RunningStatus.RUNNING;
8285
}
8386

84-
const attemptStartComputation = useCallback(() => {
85-
if (isDirtyComputationParameters) {
86-
setIsLaunchingPopupOpen(true);
87-
} else {
88-
runnables[selectedRunnable].startComputation();
89-
}
90-
}, [isDirtyComputationParameters, runnables, selectedRunnable]);
87+
const attemptStartComputation = useCallback(
88+
(debug) => {
89+
if (isDirtyComputationParameters) {
90+
setIsLaunchingPopupOpen(true);
91+
setRunWithDebug(debug);
92+
} else {
93+
runnables[selectedRunnable].startComputation(debug);
94+
}
95+
},
96+
[isDirtyComputationParameters, runnables, selectedRunnable]
97+
);
9198

9299
const handleLaunchingPopupClose = useCallback(() => {
93100
setIsLaunchingPopupOpen(false);
94101
}, []);
95102

96103
const handleLaunchingPopup = useCallback(() => {
97104
setIsLaunchingPopupOpen(false);
98-
runnables[selectedRunnable].startComputation();
99-
}, [runnables, selectedRunnable]);
105+
runnables[selectedRunnable].startComputation(runWithDebug);
106+
}, [runnables, selectedRunnable, runWithDebug]);
100107

101108
return (
102109
<>

0 commit comments

Comments
 (0)