create security node and adjust creation rules for network modificati… (#3028)

* create security node and adjust creation rules for network modification nodes 
---------

Signed-off-by: SOUISSI Maissa (Externe) <[email protected]>

Author: souissimai

src/components/graph/menus/create-node-menu.tsx

@@ -18,7 +18,7 @@ import { type AppState, type NodeSelectionForCopy } from 'redux/reducer';
 import { UUID } from 'crypto';
 import NetworkModificationTreeModel from '../network-modification-tree-model';
 import { CopyType } from 'components/network-modification.type';
-import { CurrentTreeNode, isSecurityModificationNode, NodeType } from '../tree-node.type';
+import { CurrentTreeNode, isSecurityModificationNode, NetworkModificationNodeType, NodeType } from '../tree-node.type';
 import { NodeInsertModes } from 'types/notification-types';
 import { useParameterState } from 'components/dialogs/parameters/use-parameters-state';
 import { PARAM_DEVELOPER_MODE } from 'utils/config-params';
@@ -44,7 +44,12 @@ type NodeMenuItems = Record<string, MenuItem>;
 
 interface CreateNodeMenuProps {
     position: { x: number; y: number };
-    handleNodeCreation: (element: CurrentTreeNode, type: NodeType, insertMode: NodeInsertModes) => void;
+    handleNodeCreation: (
+        element: CurrentTreeNode,
+        type: NodeType,
+        insertMode: NodeInsertModes,
+        networkModificationNodeType: NetworkModificationNodeType
+    ) => void;
     handleSecuritySequenceCreation: (element: CurrentTreeNode) => void;
     handleNodeRemoval: (activeNode: CurrentTreeNode) => void;
     handleClose: () => void;
@@ -135,8 +140,11 @@ const CreateNodeMenu: React.FC<CreateNodeMenuProps> = ({
         handleClose();
     }
 
-    function createNetworkModificationNode(insertMode: NodeInsertModes) {
-        handleNodeCreation(activeNode, NodeType.NETWORK_MODIFICATION, insertMode);
+    function createNetworkModificationNode(
+        insertMode: NodeInsertModes,
+        networkModificationNodeType: NetworkModificationNodeType
+    ) {
+        handleNodeCreation(activeNode, NodeType.NETWORK_MODIFICATION, insertMode, networkModificationNodeType);
         handleClose();
     }
 
@@ -265,24 +273,58 @@ const CreateNodeMenu: React.FC<CreateNodeMenuProps> = ({
                 activeNode?.data?.globalBuildStatus === BUILD_STATUS.BUILDING ||
                 isModificationsInProgress,
         },
-        CREATE_MODIFICATION_NODE: {
+        CREATE_MODIFICATION_NODE_CONSTRUCTION: {
             onRoot: true,
-            hidden: isSecurityModificationNode(activeNode),
-            id: 'createNetworkModificationNode',
+            disabled: isSecurityModificationNode(activeNode),
+
+            id: 'createNetworkModificationConstructionNode',
+            subMenuItems: {
+                CREATE_MODIFICATION_NODE: {
+                    onRoot: true,
+                    action: () =>
+                        createNetworkModificationNode(
+                            NodeInsertModes.NewBranch,
+                            NetworkModificationNodeType.CONSTRUCTION
+                        ),
+                    id: 'createNetworkModificationNodeInNewBranch',
+                },
+                INSERT_MODIFICATION_NODE_BEFORE: {
+                    onRoot: false,
+
+                    action: () =>
+                        createNetworkModificationNode(NodeInsertModes.Before, NetworkModificationNodeType.CONSTRUCTION),
+                    id: 'insertNetworkModificationNodeAbove',
+                },
+                INSERT_MODIFICATION_NODE_AFTER: {
+                    onRoot: true,
+                    action: () =>
+                        createNetworkModificationNode(NodeInsertModes.After, NetworkModificationNodeType.CONSTRUCTION),
+                    id: 'insertNetworkModificationNodeBelow',
+                },
+            },
+        },
+        CREATE_MODIFICATION_NODE_SECURITY: {
+            onRoot: true,
+            id: 'createNetworkModificationSecurityNode',
             subMenuItems: {
                 CREATE_MODIFICATION_NODE: {
                     onRoot: true,
-                    action: () => createNetworkModificationNode(NodeInsertModes.NewBranch),
+                    action: () =>
+                        createNetworkModificationNode(NodeInsertModes.NewBranch, NetworkModificationNodeType.SECURITY),
                     id: 'createNetworkModificationNodeInNewBranch',
                 },
                 INSERT_MODIFICATION_NODE_BEFORE: {
                     onRoot: false,
-                    action: () => createNetworkModificationNode(NodeInsertModes.Before),
+                    disabled: !isSecurityModificationNode(activeNode),
+                    action: () =>
+                        createNetworkModificationNode(NodeInsertModes.Before, NetworkModificationNodeType.SECURITY),
                     id: 'insertNetworkModificationNodeAbove',
                 },
                 INSERT_MODIFICATION_NODE_AFTER: {
                     onRoot: true,
-                    action: () => createNetworkModificationNode(NodeInsertModes.After),
+                    disabled: !isSecurityModificationNode(activeNode),
+                    action: () =>
+                        createNetworkModificationNode(NodeInsertModes.After, NetworkModificationNodeType.SECURITY),
                     id: 'insertNetworkModificationNodeBelow',
                 },
             },

src/components/network-modification-tree-pane.jsx

@@ -345,14 +345,15 @@ export const NetworkModificationTreePane = ({ studyUuid, studyMapTreeDisplay, cu
     ]);
 
     const handleCreateNode = useCallback(
-        (element, type, insertMode) => {
+        (element, type, insertMode, networkModificationNodeType) => {
             getUniqueNodeName(studyUuid)
                 .then((response) =>
                     createTreeNode(studyUuid, element.id, insertMode, {
                         name: response,
                         type: type,
                         localBuildStatus: BUILD_STATUS.NOT_BUILT,
                         globalBuildStatus: BUILD_STATUS.NOT_BUILT,
+                        nodeType: networkModificationNodeType,
                     }).catch((error) => {
                         snackError({
                             messageTxt: error.message,

src/translations/en.json

@@ -501,7 +501,8 @@
     "loadingOptions": "Loading...",
     "buildNode": "Build node",
     "maxBuiltNodeExceededError": "You have reached your user quota for builds per study, therefore you cannot build further nodes within this study. Please unbuild nodes in order to go below the limit of {limit} builds",
-    "createNetworkModificationNode": "Create a new node",
+    "createNetworkModificationConstructionNode": "Create a construction node",
+    "createNetworkModificationSecurityNode": "Create a security node",
     "createNetworkModificationNodeInNewBranch": "in a new branch",
     "pasteNetworkModificationNodeInNewBranch": "in a new branch",
     "createSecuritySequence": "Create a security sequence",

src/translations/fr.json

@@ -501,7 +501,8 @@
     "loadingOptions": "Chargement...",
     "buildNode": "Réaliser le nœud",
     "maxBuiltNodeExceededError": "Vous avez atteint votre quota utilisateur en termes de réalisations par étude, vous ne pouvez donc plus réaliser de nœuds dans cette étude pour le moment. Merci de déréaliser des nœuds afin de redescendre sous le seuil de {limit} réalisations.",
-    "createNetworkModificationNode": "Créer un nouveau nœud",
+    "createNetworkModificationConstructionNode": "Créer un nœud de construction",
+    "createNetworkModificationSecurityNode": "Créer un nœud de sécurité",
     "createNetworkModificationNodeInNewBranch": "dans une nouvelle branche",
     "pasteNetworkModificationNodeInNewBranch": "dans une nouvelle branche",
     "createSecuritySequence": "Créer un enchaînement de sécurité",