Limit spreadsheet column formula length to 1000 characters (#3429)

Signed-off-by: Franck LECUYER <[email protected]>

Author: FranckLecuyer

src/components/spreadsheet-view/columns/column-creation-dialog.tsx

@@ -46,6 +46,8 @@ import {
 import { AppState } from 'redux/reducer';
 import { createSpreadsheetColumn, updateSpreadsheetColumn } from '../../../services/study/study-config';
 import { FloatingPopoverTreeviewWrapper } from './floating-treeview-list/floating-popover-treeview-wrapper';
+import { isFormulaContentSizeOk } from './utils/formula-validator';
+import { MAX_FORMULA_CHARACTERS } from '../constants';
 
 export type ColumnCreationDialogProps = {
     open: UseStateBooleanReturn;
@@ -144,7 +146,9 @@ export default function ColumnCreationDialog({
                 label="spreadsheet/custom_column/column_content"
                 minRows={3}
                 rows={3}
+                maxCharactersNumber={MAX_FORMULA_CHARACTERS}
                 sx={{ flexGrow: 1 }}
+                acceptValue={isFormulaContentSizeOk}
             />
         </FloatingPopoverTreeviewWrapper>
     );

src/components/spreadsheet-view/columns/utils/formula-validator.ts

@@ -5,6 +5,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 import { COLUMN_TYPES } from 'components/custom-aggrid/custom-aggrid-header.type';
+import { MAX_FORMULA_CHARACTERS } from '../../constants';
 
 interface ValidationResult {
     isValid: boolean;
@@ -36,3 +37,7 @@ export const validateFormulaResult = (value: any, type: COLUMN_TYPES): Validatio
             return { isValid: false, error: 'Unknown column type' };
     }
 };
+
+export const isFormulaContentSizeOk = (val: string) => {
+    return val?.length <= MAX_FORMULA_CHARACTERS;
+};

src/components/spreadsheet-view/constants.ts

@@ -8,6 +8,7 @@
 import { ColumnState } from 'ag-grid-community';
 
 export const ROW_INDEX_COLUMN_ID = 'rowIndex';
+export const MAX_FORMULA_CHARACTERS = 1000;
 
 export const ROW_INDEX_COLUMN_STATE: ColumnState = {
     colId: ROW_INDEX_COLUMN_ID,

src/components/spreadsheet-view/spreadsheet/spreadsheet-toolbar/global-model-editor/formula-editor.tsx

@@ -10,6 +10,8 @@ import { useTheme } from '@mui/material/styles';
 import { useMemo } from 'react';
 import { useFormContext, useWatch } from 'react-hook-form';
 import { useFormulaSearch } from './formula-search-context';
+import { isFormulaContentSizeOk } from 'components/spreadsheet-view/columns/utils/formula-validator';
+import { MAX_FORMULA_CHARACTERS } from '../../../constants';
 
 const styles = {
     container: {
@@ -104,7 +106,15 @@ export default function FormulaEditor({ name }: Readonly<ExpandingTextFieldProps
             <Box aria-hidden sx={overlaySx}>
                 {highlighted}
             </Box>
-            <ExpandingTextField name={name} label="" minRows={3} rows={3} sx={styles.textField} />
+            <ExpandingTextField
+                name={name}
+                label=""
+                minRows={3}
+                rows={3}
+                maxCharactersNumber={MAX_FORMULA_CHARACTERS}
+                sx={styles.textField}
+                acceptValue={isFormulaContentSizeOk}
+            />
         </Box>
     );
 }