fix: use commons-ui config params api (app specific) (#3153)

* fix: use commons-ui config params api (app specific)

Signed-off-by: Joris Mancini <[email protected]>

* chore: update commons-ui version

Signed-off-by: Joris Mancini <[email protected]>

---------

Signed-off-by: Joris Mancini <[email protected]>

Author: TheMaskedTurtle

package-lock.json

@@ -11,7 +11,7 @@
     "dependencies": {
         "@emotion/react": "^11.14.0",
         "@emotion/styled": "^11.14.0",
-        "@gridsuite/commons-ui": "0.119.2",
+        "@gridsuite/commons-ui": "0.120.0",
         "@hello-pangea/dnd": "^18.0.1",
         "@hookform/resolvers": "^4.0.0",
         "@mui/icons-material": "^5.16.14",

package.json

@@ -17,18 +17,20 @@ import {
     AnnouncementNotification,
     AuthenticationRouter,
     CardErrorBoundary,
+    COMMON_APP_NAME,
+    fetchConfigParameter,
+    fetchConfigParameters,
     getPreLoginPath,
     initializeAuthenticationProd,
+    LAST_SELECTED_DIRECTORY,
     NotificationsUrlKeys,
     useNotificationsListener,
     useSnackMessage,
-    LAST_SELECTED_DIRECTORY,
 } from '@gridsuite/commons-ui';
 import PageNotFound from './page-not-found';
 import { FormattedMessage } from 'react-intl';
 import {
     APP_NAME,
-    COMMON_APP_NAME,
     PARAM_DEVELOPER_MODE,
     PARAM_FAVORITE_CONTINGENCY_LISTS,
     PARAM_LANGUAGE,
@@ -38,7 +40,6 @@ import {
 import { getComputedLanguage } from '../utils/language';
 import AppTopBar from './app-top-bar';
 import { StudyContainer } from './study-container';
-import { fetchConfigParameter, fetchConfigParameters } from '../services/config';
 import { fetchDefaultParametersValues, fetchIdpSettings } from '../services/utils';
 import { getOptionalServices } from '../services/study/index';
 import {
@@ -136,7 +137,7 @@ const App = () => {
         (event) => {
             let eventData = JSON.parse(event.data);
             if (eventData.headers && eventData.headers['parameterName']) {
-                fetchConfigParameter(eventData.headers['parameterName'])
+                fetchConfigParameter(APP_NAME, eventData.headers['parameterName'])
                     .then((param) => {
                         updateParams([param]);
                     })

src/components/app.jsx

@@ -8,10 +8,11 @@
 import { useCallback, useEffect, useState } from 'react';
 import { useSelector } from 'react-redux';
 
-import { useSnackMessage, updateConfigParameter } from '@gridsuite/commons-ui';
+import { updateConfigParameter, useSnackMessage } from '@gridsuite/commons-ui';
 import { AppConfigState } from 'redux/reducer';
 
 import { simpleConverterToString } from '../../../utils/types-utils';
+import { APP_NAME } from '../../../utils/config-params';
 
 // Overload for primitive types: paramValueUpdateConvertor is optional
 export function useParameterState<K extends keyof AppConfigState>(
@@ -44,15 +45,17 @@ export function useParameterState<K extends keyof AppConfigState>(
     const handleChangeParamLocalState = useCallback(
         (value: AppConfigState[K]) => {
             setParamLocalState(value);
-            updateConfigParameter(paramName, (paramValueUpdateConvertor ?? simpleConverterToString)(value)).catch(
-                (error) => {
-                    setParamLocalState(paramGlobalState);
-                    snackError({
-                        messageTxt: error.message,
-                        headerId: 'paramsChangingError',
-                    });
-                }
-            );
+            updateConfigParameter(
+                APP_NAME,
+                paramName,
+                (paramValueUpdateConvertor ?? simpleConverterToString)(value)
+            ).catch((error) => {
+                setParamLocalState(paramGlobalState);
+                snackError({
+                    messageTxt: error.message,
+                    headerId: 'paramsChangingError',
+                });
+            });
         },
         [paramName, snackError, paramGlobalState, paramValueUpdateConvertor]
     );

src/components/dialogs/parameters/use-parameters-state.ts

@@ -5,9 +5,6 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-import { LAST_SELECTED_DIRECTORY } from '@gridsuite/commons-ui';
-
-export const COMMON_APP_NAME = 'common';
 export const APP_NAME = 'study';
 
 // Commons config names
@@ -35,14 +32,3 @@ export const PARAM_PROVIDER_OPENLOADFLOW = 'OpenLoadFlow';
 export const PARAM_PROVIDER_DYNAFLOW = 'DynaFlow';
 
 export const basemap_style_theme_key = (basemap: string) => basemap + 'Style';
-
-const COMMON_CONFIG_PARAMS_NAMES = new Set([
-    PARAM_THEME,
-    PARAM_LANGUAGE,
-    LAST_SELECTED_DIRECTORY,
-    PARAM_DEVELOPER_MODE,
-]);
-
-export function getAppName(paramName: string) {
-    return COMMON_CONFIG_PARAMS_NAMES.has(paramName) ? COMMON_APP_NAME : APP_NAME;
-}