Skip to content

Conversation

flomillot
Copy link
Contributor

@flomillot flomillot commented Sep 17, 2025

When editing an existing TWT and when the user enable onload, we autofill the regulation attributes with the current network values

@flomillot flomillot changed the title Add callback to populate unset regulation attributes with previous values Add callback to populate unset ratio tap changer regulation attributes with previous values Sep 17, 2025
@Mathieu-Deharbe Mathieu-Deharbe self-requested a review September 17, 2025 12:47
Copy link
Contributor

@Mathieu-Deharbe Mathieu-Deharbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I set "En charge" to true "Mode de réglage" is selected but "Type de réglage" is not You can the previous value "local) here :
image

This is not a required value so we can validate the form and ignore it. But the jira ticket precised that this value should be filled as well. Maybe you could check with the PO if this is is really required.

Edit : it works fine if there is a previous "côté réglé". The problem is only when there is none. Maybe my data is abnormal.

Edit : my data seems to be obsolete, this shouldn't exist and can be ignored.

Mathieu-Deharbe

This comment was marked as resolved.

Copy link
Contributor

@Mathieu-Deharbe Mathieu-Deharbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and test OK.
But you will have to obey to GitHub Actions about the missing dependency: 'voltageLevelOptions' !

Copy link

@flomillot flomillot merged commit 0a0307d into main Sep 23, 2025
5 checks passed
@flomillot flomillot deleted the autofill-ratio-tap-changer-attributes branch September 23, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants