Skip to content

Commit d511ad4

Browse files
replace utility function by lombok ;)
1 parent 415c200 commit d511ad4

File tree

2 files changed

+11
-17
lines changed

2 files changed

+11
-17
lines changed

src/main/java/org/gridsuite/network/map/dto/common/CurrentLimitsData.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import lombok.Builder;
1111
import lombok.EqualsAndHashCode;
1212
import lombok.Getter;
13+
import lombok.With;
1314
import org.springframework.util.CollectionUtils;
1415

1516
import java.util.List;
@@ -20,6 +21,7 @@
2021
* == a powsybl OperationalLimitsGroup == a LimitSet
2122
*/
2223
@Builder
24+
@With
2325
@Getter
2426
@EqualsAndHashCode
2527
public class CurrentLimitsData {

src/main/java/org/gridsuite/network/map/dto/utils/ElementUtils.java

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -93,14 +93,6 @@ public static void buildCurrentLimits(Collection<OperationalLimitsGroup> current
9393
}
9494
}
9595

96-
private static CurrentLimitsData copyCurrentLimitsData(CurrentLimitsData currentLimitsData, CurrentLimitsData.Applicability applicability) {
97-
return CurrentLimitsData.builder()
98-
.id(currentLimitsData.getId())
99-
.applicability(applicability)
100-
.temporaryLimits(currentLimitsData.getTemporaryLimits())
101-
.permanentLimit(currentLimitsData.getPermanentLimit()).build();
102-
}
103-
10496
/**
10597
* Combine 2 sides in one list.
10698
* @return id of the selected operation limits group 1 and 2 if they have been renamed
@@ -120,14 +112,14 @@ public static void mergeCurrentLimits(Collection<OperationalLimitsGroup> operati
120112
// simple case : one of the arrays are empty
121113
if (currentLimitsData2.isEmpty() && !currentLimitsData1.isEmpty()) {
122114
for (final CurrentLimitsData currentLimitsData : currentLimitsData1) {
123-
mergedLimitsData.add(copyCurrentLimitsData(currentLimitsData, SIDE1));
115+
mergedLimitsData.add(currentLimitsData.withApplicability(SIDE1));
124116
}
125117
build.accept(mergedLimitsData);
126118
return;
127119
}
128120
if (currentLimitsData1.isEmpty() && !currentLimitsData2.isEmpty()) {
129121
for (final CurrentLimitsData currentLimitsData : currentLimitsData2) {
130-
mergedLimitsData.add(copyCurrentLimitsData(currentLimitsData, SIDE2));
122+
mergedLimitsData.add(currentLimitsData.withApplicability(SIDE2));
131123
}
132124
build.accept(mergedLimitsData);
133125
return;
@@ -139,24 +131,24 @@ public static void mergeCurrentLimits(Collection<OperationalLimitsGroup> operati
139131
if (l2.isPresent()) {
140132
CurrentLimitsData limitsData2 = l2.get();
141133
if (limitsData.hasLimits() && !limitsData2.hasLimits()) { // Only side one has limits
142-
mergedLimitsData.add(copyCurrentLimitsData(limitsData, SIDE1));
134+
mergedLimitsData.add(limitsData.withApplicability(SIDE1));
143135
} else if (limitsData2.hasLimits() && !limitsData.hasLimits()) { // only side two has limits
144-
mergedLimitsData.add(copyCurrentLimitsData(limitsData2, SIDE2));
136+
mergedLimitsData.add(limitsData2.withApplicability(SIDE2));
145137
} else if (limitsData.limitsEquals(limitsData2)) { // both sides have limits and limits are equals
146-
mergedLimitsData.add(copyCurrentLimitsData(limitsData, EQUIPMENT));
138+
mergedLimitsData.add(limitsData.withApplicability(EQUIPMENT));
147139
} else { // both side have limits and are different : create 2 different limit sets
148-
mergedLimitsData.add(copyCurrentLimitsData(limitsData, SIDE1));
149-
mergedLimitsData.add(copyCurrentLimitsData(limitsData2, SIDE2));
140+
mergedLimitsData.add(limitsData.withApplicability(SIDE1));
141+
mergedLimitsData.add(limitsData2.withApplicability(SIDE2));
150142
}
151143
currentLimitsData2.remove(l2.get()); // remove processed limits from side 2
152144
} else {
153-
mergedLimitsData.add(copyCurrentLimitsData(limitsData, SIDE1));
145+
mergedLimitsData.add(limitsData.withApplicability(SIDE1));
154146
}
155147
}
156148

157149
// add remaining limits from side 2
158150
for (CurrentLimitsData limitsData : currentLimitsData2) {
159-
mergedLimitsData.add(copyCurrentLimitsData(limitsData, SIDE2));
151+
mergedLimitsData.add(limitsData.withApplicability(SIDE2));
160152
}
161153

162154
if (!mergedLimitsData.isEmpty()) {

0 commit comments

Comments
 (0)