get all voltage level connections #277
Conversation
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
src/main/java/org/gridsuite/network/map/dto/definition/voltagelevel/FeederBayInfos.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/network/map/dto/mapper/VoltageLevelInfosMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/network/map/dto/mapper/VoltageLevelInfosMapper.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * @author Slimane Amar <slimane.amar at rte-france.com> | ||
| */ | ||
| public class BusbarSectionFinderTraverser implements Terminal.TopologyTraverser { |
There was a problem hiding this comment.
Move those changes in another PR. So the review can be done with #288. And the changes in the tests will be reviewed with it
| } | ||
| } | ||
|
|
||
| public static ConnectablePositionInfos toMapConnectablePosition(Identifiable<?> identifiable, int index) { |
There was a problem hiding this comment.
| public static ConnectablePositionInfos toMapConnectablePosition(Identifiable<?> identifiable, int index) { | |
| public static ConnectablePositionInfos getConnectablePosition(Identifiable<?> identifiable, ThreeSides side) { |
There was a problem hiding this comment.
I agree with the renaming, but not with changing int index to ThreeSides side, because we need to specify the index to retrieve the feeder
src/main/java/org/gridsuite/network/map/dto/mapper/VoltageLevelInfosMapper.java
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| private static ConnectablePosition.Feeder getFeederInfos(Identifiable<?> identifiable, int index) { |
There was a problem hiding this comment.
This code should use ThreeSides
| private static ConnectablePosition.Feeder getFeederInfos(Identifiable<?> identifiable, int index) { | |
| private static ConnectablePosition.Feeder getFeederInfos(Identifiable<?> identifiable, ThreeSides side) { |
There was a problem hiding this comment.
With the index we can handle injections and branches, but the ThreeSides type cannot manage that
There was a problem hiding this comment.
Discussed with Ghazwa: we'll use an enum like this one https://github.com/gridsuite/network-modification/blob/d7afbc7e5a5f1897c0c6d87e3415e69cf84f3953/src/main/java/org/gridsuite/modification/utils/ModificationUtils.java#L66
src/main/java/org/gridsuite/network/map/dto/utils/ElementUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/network/map/dto/utils/ElementUtils.java
Outdated
Show resolved
Hide resolved
|
…ge-levels-connections
| /** | ||
| * @author Slimane Amar <slimane.amar at rte-france.com> | ||
| */ | ||
| public class BusbarSectionFinderTraverser implements Terminal.TopologyTraverser { |
| BRANCH_SIDE_ONE, | ||
| BRANCH_SIDE_TWO; | ||
|
|
||
| public static FeederSide from(Optional<ThreeSides> connectableSide) { |
There was a problem hiding this comment.
public static FeederSide from(Optional<ThreeSides> connectableSide) {
if (connectableSide.isEmpty()) {
return INJECTION_SINGLE_SIDE;
}
return connectableSide.get() == ThreeSides.ONE ? BRANCH_SIDE_ONE : BRANCH_SIDE_TWO;
}
|
Reworked and finalized in #292 |
No description provided.