Fix currentLimits modification bugs (#279)

Signed-off-by: Ayoub LABIDI <[email protected]>
Co-authored-by: Etienne Homer <[email protected]>

Author: ayolab

src/main/java/org/gridsuite/modification/server/modifications/AbstractBranchModification.java

@@ -56,11 +56,14 @@ protected void modifyBranch(Branch<?> branch, BranchModificationInfos branchModi
         CurrentLimitsModificationInfos currentLimitsInfos2 = modificationInfos.getCurrentLimits2();
         List<Report> side1LimitsReports = new ArrayList<>();
         CurrentLimits currentLimits1 = branch.getCurrentLimits1().orElse(null);
-        modifyCurrentLimits(currentLimitsInfos1, branch.newCurrentLimits1(), currentLimits1, side1LimitsReports);
+        if (currentLimitsInfos1 != null) {
+            modifyCurrentLimits(currentLimitsInfos1, branch.newCurrentLimits1(), currentLimits1, side1LimitsReports);
+        }
         List<Report> side2LimitsReports = new ArrayList<>();
         CurrentLimits currentLimits2 = branch.getCurrentLimits2().orElse(null);
-        modifyCurrentLimits(currentLimitsInfos2, branch.newCurrentLimits2(), currentLimits2, side2LimitsReports);
-
+        if (currentLimitsInfos2 != null) {
+            modifyCurrentLimits(currentLimitsInfos2, branch.newCurrentLimits2(), currentLimits2, side2LimitsReports);
+        }
         if (!side1LimitsReports.isEmpty() || !side2LimitsReports.isEmpty()) {
             Reporter limitsReporter = subReporter.createSubReporter("limits", "Limits");
             limitsReporter.report(Report.builder()

src/test/java/org/gridsuite/modification/server/modifications/LineModificationTest.java

@@ -316,5 +316,20 @@ public void testTemporaryLimitsModification() throws Exception {
         LineModificationInfos createdModification = (LineModificationInfos) modificationRepository.getModifications(getGroupId(), false, true).get(0);
 
         assertThat(createdModification).recursivelyEquals(lineModificationInfos);
+
+        // Modify name and no modification on temporary limits
+        line.setName(null);
+        LineModificationInfos lineModificationInfos1 = LineModificationInfos.builder()
+                .equipmentId("line1")
+                .equipmentName(new AttributeModification<>("ModifiedName", OperationType.SET))
+                .build();
+        modificationToCreateJson = mapper.writeValueAsString(lineModificationInfos1);
+
+        mockMvc.perform(post(getNetworkModificationUri()).content(modificationToCreateJson).contentType(MediaType.APPLICATION_JSON))
+                .andExpect(status().isOk()).andReturn();
+
+        createdModification = (LineModificationInfos) modificationRepository.getModifications(getGroupId(), false, true).get(1);
+
+        assertThat(createdModification).recursivelyEquals(lineModificationInfos1);
     }
 }