Revert tabular modification optimization when moving a modification (#718)

Signed-off-by: David BRAQUART <[email protected]>

Author: dbraquart

src/main/java/org/gridsuite/modification/server/repositories/NetworkModificationRepository.java

@@ -169,7 +169,8 @@ private List<ModificationEntity> saveModificationsNonTransactional(UUID groupUui
     @Transactional
     public List<ModificationEntity> moveModifications(UUID destinationGroupUuid, UUID originGroupUuid, List<UUID> modificationsToMoveUUID, UUID referenceModificationUuid) {
         List<ModificationEntity> movedModifications = moveModificationsNonTransactional(destinationGroupUuid, originGroupUuid, modificationsToMoveUUID, referenceModificationUuid);
-        loadFullModificationsEntities(movedModifications);
+        // TODO resolve lazy initialisation exception : replace this line by loadFullModificationsEntities
+        movedModifications.forEach(ModificationEntity::toModificationInfos);
         return movedModifications;
     }
 

src/test/java/org/gridsuite/modification/server/service/ModificationRepositoryTest.java

@@ -511,7 +511,7 @@ void testMoveModificationInSameGroup() {
 
         SQLStatementCountValidator.reset();
         networkModificationRepository.moveModifications(TEST_GROUP_ID, TEST_GROUP_ID, List.of(tabularModificationEntity.getId()), groovyScriptEntity2.getId());
-        assertRequestsCount(6, 0, 2, 0);
+        assertRequestsCount(12, 0, 2, 0);
 
         var modification = networkModificationRepository.getModifications(TEST_GROUP_ID, true, true);
         // [0:1, 1:6, 2:2, 3:3, 4:4 ,5:5 ]
@@ -522,7 +522,7 @@ void testMoveModificationInSameGroup() {
 
         SQLStatementCountValidator.reset();
         networkModificationRepository.moveModifications(TEST_GROUP_ID, TEST_GROUP_ID, List.of(groovyScriptEntity3.getId(), tabularModificationEntity.getId()), null);
-        assertRequestsCount(6, 0, 2, 0);
+        assertRequestsCount(12, 0, 2, 0);
 
         // [0:1, 1:2, 2:4, 3:5, 4:6, 5:3 ]
         modification = networkModificationRepository.getModifications(TEST_GROUP_ID, true, true);