add a missing Transactionnal, remove one not necessary

Signed-off-by: David BRAQUART <[email protected]>

Author: dbraquart

src/main/java/org/gridsuite/modification/server/repositories/NetworkModificationRepository.java

@@ -526,7 +526,6 @@ public List<ModificationInfos> getCompositeModificationsInfos(@NonNull List<UUID
         return entities;
     }
 
-    @Transactional(readOnly = true)
     public List<ModificationInfos> getActiveModificationsInfos(@NonNull UUID groupUuid) {
         return getModificationEntityStream(groupUuid).filter(m -> !m.getStashed()).map(this::getModificationInfos).toList();
     }

src/main/java/org/gridsuite/modification/server/service/NetworkModificationService.java

@@ -296,6 +296,7 @@ public NetworkModificationsResult moveModifications(@NonNull UUID destinationGro
         return new NetworkModificationsResult(modificationEntities.stream().map(ModificationEntity::getId).toList(), result);
     }
 
+    @Transactional
     public Map<UUID, UUID> duplicateGroup(UUID sourceGroupUuid, UUID groupUuid) {
         try {
             List<ModificationInfos> modificationToDuplicateInfos = networkModificationRepository.getActiveModificationsInfos(sourceGroupUuid);

src/test/java/org/gridsuite/modification/server/modifications/tabularmodifications/TabularGeneratorModificationsTest.java

@@ -170,7 +170,7 @@ void testSqlRequestsCountOnPostGroups() throws Exception {
 
         reset();
         ApiUtils.postGroups(mockMvc, getGroupId(), targetGroupUuid);
-        TestUtils.assertRequestsCount(13, 9, 2, 0); // (13, 9, 2, 0) before improvements
+        TestUtils.assertRequestsCount(12, 9, 2, 0); // (13, 9, 2, 0) before improvements
         assertTabularModificationsEquals(modifications, targetGroupUuid);
     }
 
@@ -181,7 +181,7 @@ void testSqlRequestsCountOnPostGroups2() throws Exception {
 
         reset();
         ApiUtils.postGroups(mockMvc, getGroupId(), targetGroupUuid);
-        TestUtils.assertRequestsCount(21, 10, 2, 0); // (95, 10, 2, 0) before improvements, why one additional insert ? It feels batch_size is limited at 100 for insertions and is it reached for reactive_capability_curve_points
+        TestUtils.assertRequestsCount(20, 10, 2, 0); // (95, 10, 2, 0) before improvements, why one additional insert ? It feels batch_size is limited at 100 for insertions and is it reached for reactive_capability_curve_points
         assertTabularModificationsEquals(modifications, targetGroupUuid);
     }