Set tabular modification failure log level to error instead of warn (#130)

Signed-off-by: Hugo Marcellin <[email protected]>

Author: Meklo

src/main/java/org/gridsuite/modification/modifications/tabular/AbstractTabularModification.java

@@ -55,12 +55,12 @@ public void apply(Network network, ReportNode subReportNode) {
                 applicationFailuresCount++;
                 ReportNode errorReportNode = modifReportNode.newReportNode()
                         .withMessageTemplate(baseTemplateMessage() + ".error.equipmentError")
-                        .withSeverity(TypedValue.WARN_SEVERITY)
+                        .withSeverity(TypedValue.ERROR_SEVERITY)
                         .add();
                 errorReportNode.newReportNode()
                         .withMessageTemplate(baseTemplateMessage() + ".exception")
                         .withUntypedValue("message", e.getMessage())
-                        .withSeverity(TypedValue.WARN_SEVERITY)
+                        .withSeverity(TypedValue.ERROR_SEVERITY)
                         .add();
                 LOGGER.warn(e.getMessage());
             }
@@ -73,11 +73,11 @@ public void apply(Network network, ReportNode subReportNode) {
                     .add();
         } else if (applicationFailuresCount > 0) {
             subReportNode.newReportNode()
-                    .withMessageTemplate(baseTemplateMessage() + ".warning")
+                    .withMessageTemplate(baseTemplateMessage() + ".partial")
                     .withUntypedValue("modificationsCount", modificationInfos.getModifications().size() - applicationFailuresCount)
                     .withUntypedValue("failuresCount", applicationFailuresCount)
                     .withUntypedValue(DEFAULT_MESSAGE_KEY, defaultMessage())
-                    .withSeverity(TypedValue.WARN_SEVERITY)
+                    .withSeverity(TypedValue.ERROR_SEVERITY)
                     .add();
         } else {
             subReportNode.newReportNode()

src/main/resources/org/gridsuite/modification/reports.properties

@@ -280,13 +280,13 @@ network.modification.tabular.creation.error = Tabular creation: No ${defaultMess
 network.modification.tabular.creation.exception = ${message}
 network.modification.tabular.creation.equipmentId = Creation of ${equipmentId}
 network.modification.tabular.creation.error.equipmentError = Creation errors
-network.modification.tabular.creation.warning = Tabular creation: ${modificationsCount} ${defaultMessage} and ${failuresCount} have not been created
+network.modification.tabular.creation.partial = Tabular creation: ${modificationsCount} ${defaultMessage} and ${failuresCount} have not been created
 network.modification.tabular.modification = Tabular modification: ${modificationsCount} ${defaultMessage}
 network.modification.tabular.modification.error = Tabular modification: No ${defaultMessage}
 network.modification.tabular.modification.exception = ${message}
 network.modification.tabular.modification.equipmentId = Modification of ${equipmentId}
 network.modification.tabular.modification.error.equipmentError = Modification errors
-network.modification.tabular.modification.warning = Tabular modification: ${modificationsCount} ${defaultMessage} and ${failuresCount} have not been modified
+network.modification.tabular.modification.partial = Tabular modification: ${modificationsCount} ${defaultMessage} and ${failuresCount} have not been modified
 network.modification.tabular.modification.shuntCompensator.maxSusceptanceIgnored.1 = Tabular modification: Input for maximum susceptance has been ignored since it is not possible to simultaneously update type, maximum reactive power and maximum susceptance for shunt compensator with id ${id}
 network.modification.tabular.modification.shuntCompensator.maxSusceptanceIgnored.2 = Tabular modification: Input for maximum susceptance has been ignored since it is not possible to simultaneously update type and maximum susceptance for shunt compensator with id ${id}
 network.modification.tabular.modification.shuntCompensator.maxSusceptanceIgnored.3 = Tabular modification: Input for maximum susceptance has been ignored since it is not possible to simultaneously update maximum reactive power and maximum susceptance for shunt compensator with id ${id}

src/test/java/org/gridsuite/modification/modifications/tabularmodifications/TabularBatteryModificationsTest.java

@@ -73,7 +73,7 @@ private void assertAfterNetworkModificationApplication(ReportNode reportNode) {
         assertLogNthMessage("Modification of v1Battery", "network.modification.tabular.modification.equipmentId", reportNode, 1);
         assertLogNthMessage("Modification of v2Battery", "network.modification.tabular.modification.equipmentId", reportNode, 2);
         assertLogNthMessage("Modification of v3Battery", "network.modification.tabular.modification.equipmentId", reportNode, 3);
-        assertLogMessageWithoutRank("Tabular modification: 3 batteries have been modified and 1 have not been modified", "network.modification.tabular.modification.warning", reportNode);
+        assertLogMessageWithoutRank("Tabular modification: 3 batteries have been modified and 1 have not been modified", "network.modification.tabular.modification.partial", reportNode);
     }
 
     @Override

src/test/java/org/gridsuite/modification/modifications/tabularmodifications/TabularGeneratorModificationsTest.java

@@ -74,7 +74,7 @@ private void assertAfterNetworkModificationApplication(ReportNode reportNode) {
         assertLogNthMessage("Modification of idGenerator", "network.modification.tabular.modification.equipmentId", reportNode, 1);
         assertLogNthMessage("Modification of v5generator", "network.modification.tabular.modification.equipmentId", reportNode, 2);
         assertLogNthMessage("Modification of v6generator", "network.modification.tabular.modification.equipmentId", reportNode, 3);
-        assertLogMessageWithoutRank("Tabular modification: 3 generators have been modified and 1 have not been modified", "network.modification.tabular.modification.warning", reportNode);
+        assertLogMessageWithoutRank("Tabular modification: 3 generators have been modified and 1 have not been modified", "network.modification.tabular.modification.partial", reportNode);
     }
 
     @Test

src/test/java/org/gridsuite/modification/modifications/tabularmodifications/TabularLineModificationsTest.java

@@ -76,7 +76,7 @@ private void assertAfterNetworkModificationApplication(ReportNode reportNode) {
         assertLogNthMessage("Modification of line2", "network.modification.tabular.modification.equipmentId", reportNode, 2);
         assertLogNthMessage("Modification of line3", "network.modification.tabular.modification.equipmentId", reportNode, 3);
         assertLogNthMessage("Modification of line3", "network.modification.tabular.modification.equipmentId", reportNode, 4);
-        assertLogMessageWithoutRank("Tabular modification: 4 lines have been modified and 1 have not been modified", "network.modification.tabular.modification.warning", reportNode);
+        assertLogMessageWithoutRank("Tabular modification: 4 lines have been modified and 1 have not been modified", "network.modification.tabular.modification.partial", reportNode);
     }
 
     @Override

src/test/java/org/gridsuite/modification/modifications/tabularmodifications/TabularTwoWindingsTransformerModificationsTest.java

@@ -76,7 +76,7 @@ private void assertAfterNetworkModificationApplication(ReportNode reportNode) {
         assertAfterNetworkModificationApplication();
         assertLogNthMessage("Modification of trf1", "network.modification.tabular.modification.equipmentId", reportNode, 1);
         assertLogNthMessage("Modification of trf2", "network.modification.tabular.modification.equipmentId", reportNode, 2);
-        assertLogMessageWithoutRank("Tabular modification: 2 two windings transformers have been modified and 1 have not been modified", "network.modification.tabular.modification.warning", reportNode);
+        assertLogMessageWithoutRank("Tabular modification: 2 two windings transformers have been modified and 1 have not been modified", "network.modification.tabular.modification.partial", reportNode);
     }
 
     @Override