fix check and application when missing data on angle droop active power modification (#140)

Signed-off-by: Etienne LESOT <[email protected]>

Author: EtienneLt

src/main/java/org/gridsuite/modification/modifications/VscModification.java

@@ -107,9 +107,9 @@ private void checkDroop(HvdcLine hvdcLine) {
         }
 
         //--- the extension doesn't exist yet ---//
-        boolean isPresentAngleDroopActivePowerControl = modificationInfos.getAngleDroopActivePowerControl() != null;
-        boolean isPresentDroop = modificationInfos.getDroop() != null;
-        boolean isPresentP0 = modificationInfos.getP0() != null;
+        boolean isPresentAngleDroopActivePowerControl = modificationInfos.getAngleDroopActivePowerControl() != null && modificationInfos.getAngleDroopActivePowerControl().getValue() != null;
+        boolean isPresentDroop = modificationInfos.getDroop() != null && modificationInfos.getDroop().getValue() != null;
+        boolean isPresentP0 = modificationInfos.getP0() != null && modificationInfos.getP0().getValue() != null;
         // all fields are provided => OK extension will be created
         if (isPresentAngleDroopActivePowerControl && isPresentDroop && isPresentP0) {
             return;
@@ -280,7 +280,10 @@ private void modifyExistingHvdcAngleDroopActivePowerControl(HvdcAngleDroopActive
 
     private boolean shouldCreateDroopActivePowerControlExtension() {
         return shouldCreateDroopActivePowerControlExtension(
-            modificationInfos.getAngleDroopActivePowerControl() != null, modificationInfos.getDroop() != null, modificationInfos.getP0() != null);
+                modificationInfos.getAngleDroopActivePowerControl() != null &&
+                        modificationInfos.getAngleDroopActivePowerControl().getValue() != null,
+                modificationInfos.getDroop() != null && modificationInfos.getDroop().getValue() != null,
+                modificationInfos.getP0() != null && modificationInfos.getP0().getValue() != null);
     }
 
     private List<ReportNode> hvdcAngleDroopActivePowerControlAdder(HvdcLine hvdcLine) {

src/test/java/org/gridsuite/modification/modifications/VscModificationTest.java

@@ -225,13 +225,13 @@ private VscModificationInfos buildModificationWithDroopAbsentInfos(boolean isPre
         VscModificationInfos modificationInfos = (VscModificationInfos) buildModification();
         // reset null depending to test arguments
         if (!isPresentAngleDroopActivePowerControl) {
-            modificationInfos.setAngleDroopActivePowerControl(null);
+            modificationInfos.setAngleDroopActivePowerControl(new AttributeModification<>(null, null));
         }
         if (!isPresentDroop) {
-            modificationInfos.setDroop(null);
+            modificationInfos.setDroop(new AttributeModification<>(null, null));
         }
         if (!isPresentP0) {
-            modificationInfos.setP0(null);
+            modificationInfos.setP0(new AttributeModification<>(null, null));
         }
         return modificationInfos;
     }