unsettable fields in voltage level filter modification #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
basseche
reviewed
Sep 17, 2025
src/main/java/org/gridsuite/modification/dto/byfilter/equipmentfield/GeneratorField.java
Outdated
Show resolved
Hide resolved
basseche
requested changes
Sep 17, 2025
basseche
reviewed
Sep 17, 2025
src/main/java/org/gridsuite/modification/modifications/GeneratorModification.java
Outdated
Show resolved
Hide resolved
basseche
reviewed
Sep 17, 2025
src/main/java/org/gridsuite/modification/modifications/GeneratorModification.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mathieu DEHARBE <[email protected]>
basseche
reviewed
Sep 25, 2025
| } | ||
| case RATED_NOMINAL_POWER -> { | ||
| Double ratedNominalPower = Double.parseDouble(newValue); | ||
| Double ratedNominalPower = newValue != null ? Double.parseDouble(newValue) : Double.NaN; |
There was a problem hiding this comment.
maybe you should make a function og this as it is repeated several times
There was a problem hiding this comment.
Done here : 50d2b43
basseche
approved these changes
Sep 25, 2025
Signed-off-by: Mathieu DEHARBE <[email protected]>
|
basseche
approved these changes
Sep 25, 2025
Mathieu-Deharbe
deleted the
unsettable-fields-in-filter-modification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.