Skip to content

adds MODIFY_OR_ADD to limit modification #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 23, 2025
Merged

adds MODIFY_OR_ADD to limit modification #95

merged 5 commits into from
Sep 23, 2025

Conversation

Mathieu-Deharbe
Copy link
Contributor

No description provided.

EtienneLt
EtienneLt approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@EtienneLt EtienneLt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add some comment on the method applyTemporaryLimitModification to specify this

@Mathieu-Deharbe
better comments
8cacfda 
Signed-off-by: Mathieu DEHARBE <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
92.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Mathieu-Deharbe Mathieu-Deharbe merged commit 5da4279 into main Sep 23, 2025
4 checks passed
@Mathieu-Deharbe Mathieu-Deharbe deleted the rework-limit-modification branch September 23, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipirog ipirog ipirog approved these changes

@EtienneLt EtienneLt EtienneLt approved these changes

@flomillot flomillot Awaiting requested review from flomillot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mathieu-Deharbe @ipirog @EtienneLt