replace ZonedDateTime with Instant (#92)

* replace LocalDateTime with ZonedDateTime
* replace ZonedDateTime with OffsetDateTime
* remove comment
* replace OffsetDateTime with Instant
---------
Signed-off-by: TOURI ANIS <[email protected]>

Author: anistouri

src/main/java/org/gridsuite/shortcircuit/server/dto/ShortCircuitAnalysisResult.java

@@ -10,7 +10,7 @@
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 
-import java.time.ZonedDateTime;
+import java.time.Instant;
 import java.util.List;
 import java.util.UUID;
 
@@ -24,7 +24,7 @@ public class ShortCircuitAnalysisResult {
 
     private UUID resultUuid;
 
-    private ZonedDateTime writeTimeStamp;
+    private Instant writeTimeStamp;
 
     private List<FaultResult> faults;
 }

src/main/java/org/gridsuite/shortcircuit/server/entities/ShortCircuitAnalysisResultEntity.java

@@ -13,7 +13,7 @@
 import jakarta.persistence.*;
 import lombok.experimental.FieldNameConstants;
 
-import java.time.ZonedDateTime;
+import java.time.Instant;
 import java.util.Set;
 import java.util.UUID;
 
@@ -30,8 +30,8 @@ public class ShortCircuitAnalysisResultEntity {
     @Id
     private UUID resultUuid;
 
-    @Column
-    private ZonedDateTime writeTimeStamp;
+    @Column(columnDefinition = "timestamptz")
+    private Instant writeTimeStamp;
 
     /*
     Bidirectional relation is not needed here and is done for performance
@@ -43,7 +43,7 @@ and having a constant hashCode() causes performance issues.
     @Setter
     private Set<FaultResultEntity> faultResults;
 
-    public ShortCircuitAnalysisResultEntity(UUID resultUuid, ZonedDateTime writeTimeStamp, Set<FaultResultEntity> faultResults) {
+    public ShortCircuitAnalysisResultEntity(UUID resultUuid, Instant writeTimeStamp, Set<FaultResultEntity> faultResults) {
         this.resultUuid = resultUuid;
         this.writeTimeStamp = writeTimeStamp;
         addFaultResults(faultResults);

src/main/java/org/gridsuite/shortcircuit/server/service/ShortCircuitAnalysisResultService.java

@@ -28,8 +28,7 @@
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
-import java.time.ZoneOffset;
-import java.time.ZonedDateTime;
+import java.time.Instant;
 import java.time.temporal.ChronoUnit;
 import java.util.*;
 import java.util.concurrent.TimeUnit;
@@ -89,7 +88,7 @@ public static ShortCircuitAnalysisResultEntity toResultEntity(UUID resultUuid, S
                 })
                 .collect(Collectors.toSet());
         //We need to limit the precision to avoid database precision storage limit issue (postgres has a precision of 6 digits while h2 can go to 9)
-        return new ShortCircuitAnalysisResultEntity(resultUuid, ZonedDateTime.now(ZoneOffset.UTC).truncatedTo(ChronoUnit.MICROS), faultResults);
+        return new ShortCircuitAnalysisResultEntity(resultUuid, Instant.now().truncatedTo(ChronoUnit.MICROS), faultResults);
     }
 
     private static FaultResultEntity toGenericFaultResultEntity(final FaultResult faultResult, final ShortCircuitLimits shortCircuitLimits) {

src/main/resources/db/changelog/changesets/changelog_20240528T161201Z.xml

@@ -0,0 +1,6 @@
+<?xml version="1.1" encoding="UTF-8" standalone="no"?>
+<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog" xmlns:ext="http://www.liquibase.org/xml/ns/dbchangelog-ext" xmlns:pro="http://www.liquibase.org/xml/ns/pro" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog-ext http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-ext.xsd http://www.liquibase.org/xml/ns/pro http://www.liquibase.org/xml/ns/pro/liquibase-pro-latest.xsd http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd">
+    <changeSet author="tourian1 (generated)" id="1716912736877-1">
+        <modifyDataType tableName="shortcircuit_result" columnName="write_time_stamp" newDataType="timestamptz"/>
+    </changeSet>
+</databaseChangeLog>

src/main/resources/db/changelog/db.changelog-master.yaml

@@ -33,3 +33,7 @@ databaseChangeLog:
   - include:
       file: changesets/changelog_20240403T090341Z.xml
       relativeToChangelogFile: true
+  - include:
+      file: changesets/changelog_20240528T161201Z.xml
+      relativeToChangelogFile: true
+

src/test/java/org/gridsuite/shortcircuit/server/ShortCircuitAnalysisControllerTest.java

@@ -54,8 +54,6 @@
 import org.springframework.test.web.servlet.MvcResult;
 
 import java.nio.charset.StandardCharsets;
-import java.time.LocalDateTime;
-import java.time.temporal.ChronoUnit;
 import java.util.*;
 import java.util.concurrent.CompletableFuture;
 import java.util.stream.Collectors;
@@ -337,8 +335,6 @@ private void cleanDB() {
 
     @Test
     public void runTest() throws Exception {
-        //We need to limit the precision to avoid database precision storage limit issue (postgres has a precision of 6 digits while h2 can go to 9)
-        LocalDateTime testTime = LocalDateTime.now().truncatedTo(ChronoUnit.MICROS);
         try (MockedStatic<ShortCircuitAnalysis> shortCircuitAnalysisMockedStatic = Mockito.mockStatic(ShortCircuitAnalysis.class)) {
 
             shortCircuitAnalysisMockedStatic.when(() -> ShortCircuitAnalysis.runAsync(eq(network), anyList(), any(ShortCircuitParameters.class), any(ComputationManager.class), anyList(), any(ReportNode.class)))
@@ -549,8 +545,6 @@ public void testDeterministicResults() throws Exception {
 
     @Test
     public void runWithBusIdTest() throws Exception {
-        //We need to limit the precision to avoid database precision storage limit issue (postgres has a precision of 6 digits while h2 can go to 9)
-        LocalDateTime testTime = LocalDateTime.now().truncatedTo(ChronoUnit.MICROS);
         try (MockedStatic<ShortCircuitAnalysis> shortCircuitAnalysisMockedStatic = Mockito.mockStatic(ShortCircuitAnalysis.class)) {
             shortCircuitAnalysisMockedStatic.when(() -> ShortCircuitAnalysis.runAsync(eq(network), anyList(), any(ShortCircuitParameters.class), any(ComputationManager.class), anyList(), any(ReportNode.class)))
                 .thenReturn(CompletableFuture.completedFuture(ShortCircuitAnalysisResultMock.RESULT_FORTESCUE_FULL));
@@ -612,8 +606,6 @@ public void runWithBusIdTest() throws Exception {
 
     @Test
     public void runWithBusBarSectionIdTest() throws Exception {
-        //We need to limit the precision to avoid database precision storage limit issue (postgres has a precision of 6 digits while h2 can go to 9)
-        LocalDateTime testTime = LocalDateTime.now().truncatedTo(ChronoUnit.MICROS);
         try (MockedStatic<ShortCircuitAnalysis> shortCircuitAnalysisMockedStatic = Mockito.mockStatic(ShortCircuitAnalysis.class)) {
             shortCircuitAnalysisMockedStatic.when(() -> ShortCircuitAnalysis.runAsync(eq(nodeBreakerNetwork), anyList(), any(ShortCircuitParameters.class), any(ComputationManager.class), anyList(), any(ReportNode.class)))
                 .thenReturn(CompletableFuture.completedFuture(ShortCircuitAnalysisResultMock.RESULT_FORTESCUE_FULL));
@@ -656,8 +648,6 @@ public void runWithBusBarSectionIdTest() throws Exception {
 
     @Test
     public void runWithBusBarSectionIdAndErrorTest() throws Exception {
-        //We need to limit the precision to avoid database precision storage limit issue (postgres has a precision of 6 digits while h2 can go to 9)
-        LocalDateTime testTime = LocalDateTime.now().truncatedTo(ChronoUnit.MICROS);
         try (MockedStatic<ShortCircuitAnalysis> shortCircuitAnalysisMockedStatic = Mockito.mockStatic(ShortCircuitAnalysis.class)) {
             shortCircuitAnalysisMockedStatic.when(() -> ShortCircuitAnalysis.runAsync(eq(nodeBreakerNetwork), anyList(), any(ShortCircuitParameters.class), any(ComputationManager.class), anyList(), any(ReportNode.class)))
                 .thenReturn(CompletableFuture.completedFuture(ShortCircuitAnalysisResultMock.RESULT_MAGNITUDE_FULL));