Skip to content

Commit d92f178

Browse files
klesaulnierLE SAULNIER Kevin
andauthored
fix: rename field to column to match security-analysis-server (#54)
Signed-off-by: LE SAULNIER Kevin <[email protected]> Co-authored-by: LE SAULNIER Kevin <[email protected]>
1 parent a2d88d8 commit d92f178

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/main/java/org/gridsuite/shortcircuit/server/dto/ResourceFilter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@
1919
* @param dataType the type of data we want to filter (text, number)
2020
* @param type the type of filter (contains, startsWith...)
2121
* @param value the value of the filter
22-
* @param field the field on which the filter will be applied
22+
* @param column the column on which the filter will be applied
2323
* @author Florent MILLOT <[email protected]>
2424
*/
25-
public record ResourceFilter(DataType dataType, Type type, Object value, String field) {
25+
public record ResourceFilter(DataType dataType, Type type, Object value, String column) {
2626

2727
private static ObjectMapper objectMapper = new ObjectMapper();
2828

src/main/java/org/gridsuite/shortcircuit/server/utils/SpecificationUtils.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -89,18 +89,18 @@ private static <X> Specification<X> appendTextFilterToSpecification(Specificatio
8989
case EQUALS -> {
9090
// this type can manage one value or a list of values (with OR)
9191
if (resourceFilter.value() instanceof Collection<?> valueList) {
92-
completedSpecification = completedSpecification.and(anyOf(valueList.stream().map(value -> SpecificationUtils.<X>equals(resourceFilter.field(), value.toString())).toList()));
92+
completedSpecification = completedSpecification.and(anyOf(valueList.stream().map(value -> SpecificationUtils.<X>equals(resourceFilter.column(), value.toString())).toList()));
9393
} else if (resourceFilter.value() == null) {
9494
// if the value is null, we build an impossible specification (trick to remove later on ?)
9595
completedSpecification = completedSpecification.and(not(completedSpecification));
9696
} else {
97-
completedSpecification = completedSpecification.and(equals(resourceFilter.field(), resourceFilter.value().toString()));
97+
completedSpecification = completedSpecification.and(equals(resourceFilter.column(), resourceFilter.value().toString()));
9898
}
9999
}
100100
case CONTAINS ->
101-
completedSpecification = completedSpecification.and(contains(resourceFilter.field(), resourceFilter.value().toString()));
101+
completedSpecification = completedSpecification.and(contains(resourceFilter.column(), resourceFilter.value().toString()));
102102
case STARTS_WITH ->
103-
completedSpecification = completedSpecification.and(startsWith(resourceFilter.field(), resourceFilter.value().toString()));
103+
completedSpecification = completedSpecification.and(startsWith(resourceFilter.column(), resourceFilter.value().toString()));
104104
default -> throwBadFilterTypeException(resourceFilter.type(), resourceFilter.dataType());
105105
}
106106

@@ -116,11 +116,11 @@ private static <X> Specification<X> appendNumberFilterToSpecification(Specificat
116116

117117
switch (resourceFilter.type()) {
118118
case NOT_EQUAL ->
119-
completedSpecification = completedSpecification.and(notEqual(resourceFilter.field(), value));
119+
completedSpecification = completedSpecification.and(notEqual(resourceFilter.column(), value));
120120
case LESS_THAN_OR_EQUAL ->
121-
completedSpecification = completedSpecification.and(lessThanOrEqual(resourceFilter.field(), value));
121+
completedSpecification = completedSpecification.and(lessThanOrEqual(resourceFilter.column(), value));
122122
case GREATER_THAN_OR_EQUAL ->
123-
completedSpecification = completedSpecification.and(greaterThanOrEqual(resourceFilter.field(), value));
123+
completedSpecification = completedSpecification.and(greaterThanOrEqual(resourceFilter.column(), value));
124124
default -> throwBadFilterTypeException(resourceFilter.type(), resourceFilter.dataType());
125125
}
126126

0 commit comments

Comments
 (0)