Refactor column visibility handling to use Boolean type and improve column sorting logic

Signed-off-by: achour94 <[email protected]>

Author: achour94

src/main/java/org/gridsuite/studyconfig/server/dto/ColumnInfos.java

@@ -54,5 +54,11 @@ public record ColumnInfos(
     Double filterTolerance,
 
     @Schema(description = "Column visibility", defaultValue = "true")
-    boolean visible
-) { }
+    Boolean visible
+) {
+    public ColumnInfos {
+        if (visible == null) {
+            visible = true;
+        }
+    }
+}

src/main/java/org/gridsuite/studyconfig/server/service/SpreadsheetConfigService.java

@@ -357,11 +357,7 @@ public void reorderColumns(UUID id, List<UUID> columnOrder) {
     }
 
     private static void reorderColumns(List<UUID> columnOrder, List<ColumnEntity> columns) {
-        columns.sort((c1, c2) -> {
-            int idx1 = columnOrder.indexOf(c1.getUuid());
-            int idx2 = columnOrder.indexOf(c2.getUuid());
-            return Integer.compare(idx1, idx2);
-        });
+        columns.sort(Comparator.comparingInt(column -> columnOrder.indexOf(column.getUuid())));
     }
 
     @Transactional
@@ -381,13 +377,11 @@ public void updateColumnStates(UUID id, List<ColumnStateUpdateInfos> columnState
         }
 
         // Reorder columns based on the provided states
-        columns.sort(Comparator.comparing(column ->
-            columnStates.stream()
-                    .filter(state -> state.columnId().equals(column.getUuid()))
-                    .findFirst()
-                    .map(ColumnStateUpdateInfos::order)
-                    .orElse(Integer.MAX_VALUE)
-        ));
+        List<UUID> orderedColumnIds = columnStates.stream()
+                .sorted(Comparator.comparingInt(ColumnStateUpdateInfos::order))
+                .map(ColumnStateUpdateInfos::columnId)
+                .toList();
+        reorderColumns(orderedColumnIds, columns);
     }
 
     private SpreadsheetConfigCollectionInfos readDefaultSpreadsheetConfigCollection() throws IOException {