add tests

Signed-off-by: achour94 <[email protected]>

Author: achour94

src/main/java/org/gridsuite/spreadsheetconfig/server/RestResponseEntityExceptionHandler.java

@@ -0,0 +1,28 @@
+/**
+ * Copyright (c) 2024, RTE (http://www.rte-france.com)
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+package org.gridsuite.spreadsheetconfig.server;
+
+import jakarta.persistence.EntityNotFoundException;
+import org.springframework.http.HttpStatus;
+import org.springframework.http.ResponseEntity;
+import org.springframework.web.bind.annotation.ControllerAdvice;
+import org.springframework.web.bind.annotation.ExceptionHandler;
+import org.springframework.web.context.request.WebRequest;
+
+/**
+ * @author Achour BERRAHMA <achour.berrahma at rte-france.com>
+ */
+@ControllerAdvice
+public class RestResponseEntityExceptionHandler {
+
+    @ExceptionHandler(EntityNotFoundException.class)
+    protected ResponseEntity<Object> handleEntityNotFound(
+            EntityNotFoundException ex, WebRequest request) {
+        String bodyOfResponse = ex.getMessage();
+        return new ResponseEntity<>(bodyOfResponse, HttpStatus.NOT_FOUND);
+    }
+}

src/test/java/org/gridsuite/spreadsheetconfig/server/SpreadsheetConfigControllerTest.java

@@ -75,6 +75,21 @@ void testCreate() throws Exception {
         assertThat(createdConfig.getCustomColumns()).allMatch(column -> column.getId() != null);
     }
 
+    @Test
+    void testCreateWithInvalidData() throws Exception {
+        SpreadsheetConfigDto invalidConfig = SpreadsheetConfigDto.builder()
+                .sheetType(null)  // SheetType is required
+                .customColumns(createCustomColumns())
+                .build();
+
+        String invalidConfigJson = mapper.writeValueAsString(invalidConfig);
+
+        mockMvc.perform(post(URI_SPREADSHEET_CONFIG_BASE)
+                        .content(invalidConfigJson)
+                        .contentType(MediaType.APPLICATION_JSON))
+                .andExpect(status().isBadRequest());
+    }
+
     @Test
     void testRead() throws Exception {
         SpreadsheetConfigDto configToRead = SpreadsheetConfigDto.builder()
@@ -94,6 +109,37 @@ void testRead() throws Exception {
         assertThat(receivedConfig.getCustomColumns()).allMatch(column -> column.getId() != null);
     }
 
+    @Test
+    void testReadNonExistent() throws Exception {
+        UUID nonExistentUuid = UUID.randomUUID();
+
+        mockMvc.perform(get(URI_SPREADSHEET_CONFIG_GET_PUT + nonExistentUuid))
+                .andExpect(status().isNotFound());
+    }
+
+    @Test
+    void testUpdateWithInvalidData() throws Exception {
+        SpreadsheetConfigDto configToUpdate = SpreadsheetConfigDto.builder()
+                .sheetType(SheetType.BATTERIES)
+                .customColumns(createCustomColumns())
+                .build();
+
+        UUID configUuid = saveAndReturnId(configToUpdate);
+
+        SpreadsheetConfigDto invalidUpdate = SpreadsheetConfigDto.builder()
+                .id(configUuid)
+                .sheetType(null)  // SheetType is required
+                .customColumns(createUpdatedCustomColumns())
+                .build();
+
+        String invalidUpdateJson = mapper.writeValueAsString(invalidUpdate);
+
+        mockMvc.perform(put(URI_SPREADSHEET_CONFIG_GET_PUT + configUuid)
+                        .content(invalidUpdateJson)
+                        .contentType(MediaType.APPLICATION_JSON))
+                .andExpect(status().isBadRequest());
+    }
+
     @Test
     void testUpdate() throws Exception {
         SpreadsheetConfigDto configToUpdate = SpreadsheetConfigDto.builder()
@@ -141,6 +187,14 @@ void testDelete() throws Exception {
         assertThat(storedConfigs).isEmpty();
     }
 
+    @Test
+    void testDeleteNonExistent() throws Exception {
+        UUID nonExistentUuid = UUID.randomUUID();
+
+        mockMvc.perform(delete(URI_SPREADSHEET_CONFIG_GET_PUT + nonExistentUuid))
+                .andExpect(status().isNotFound());
+    }
+
     @Test
     void testGetAll() throws Exception {
         SpreadsheetConfigDto config1 = SpreadsheetConfigDto.builder()
@@ -182,6 +236,15 @@ void testDuplicate() throws Exception {
         assertThat(duplicatedConfig.getId()).isNotEqualTo(configUuid);
     }
 
+    @Test
+    void testDuplicateNonExistent() throws Exception {
+        UUID nonExistentUuid = UUID.randomUUID();
+
+        mockMvc.perform(post(URI_SPREADSHEET_CONFIG_BASE + "/duplicate")
+                        .queryParam("duplicateFrom", nonExistentUuid.toString()))
+                .andExpect(status().isNotFound());
+    }
+
     private List<CustomColumnDto> createCustomColumns() {
         return Arrays.asList(
                 new CustomColumnDto(null, "cust_a", "cust_b + cust_c"),