Skip to content

get status of DS and DSA, return string not enum like other statuses #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 26, 2025
Merged

get status of DS and DSA, return string not enum like other statuses #853

merged 3 commits into from
Sep 26, 2025

Conversation

thangqp
Copy link
Contributor

@thangqp thangqp commented Sep 18, 2025 •
edited by jonenst
Loading

Related PR front : gridsuite/gridstudy-app#3292
EDIT: This PR was originally done to fix various (sometimes 1s, sometimes 200ms) performance problems but empirically this change doesn't affect performance or only in the order of miliseconds

@thangqp thangqp mentioned this pull request Sep 18, 2025
Merged
@thangqp
Correct test
0131f15 
Signed-off-by: Thang PHAM <[email protected]>
jonenst
jonenst requested changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@jonenst jonenst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to technically explain how these changes have an actual effect. If so, need to hunt down globally the places where we had similar problems

EDIT: this doesn't affect performance. We do it only to make the code more homogeneous

@jonenst jonenst changed the title Enhance performance when get status of DS and DSA get status of DS and DSA, return string not enum like other statuses Sep 26, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@thangqp thangqp merged commit 09e7d77 into main Sep 26, 2025
4 checks passed
@thangqp thangqp deleted the enhance_perf_get_status_ds_dsa branch September 26, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonenst jonenst jonenst approved these changes

@TheMaskedTurtle TheMaskedTurtle TheMaskedTurtle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thangqp @jonenst @TheMaskedTurtle