missing rollback instructions

Author: Tristan-WorkGH

src/main/resources/db/changelog/changesets/changelog_20240109T161028Z.xml

@@ -1,29 +1,31 @@
 <?xml version="1.1" encoding="UTF-8" standalone="no"?>
 <databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog" xmlns:ext="http://www.liquibase.org/xml/ns/dbchangelog-ext" xmlns:pro="http://www.liquibase.org/xml/ns/pro" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog-ext http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-ext.xsd http://www.liquibase.org/xml/ns/pro http://www.liquibase.org/xml/ns/pro/liquibase-pro-latest.xsd http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd">
     <changeSet author="chuinetri" id="1704818243021-1">
-        <comment>Deduplicate rows before adding unique constraint</comment>
+        <comment>Deduplicate rows before adding unique constraints</comment>
         <delete tableName="user_infos">
             <where>id in (select id from (select row_number() over (partition by sub) as rnb, * from user_infos) subquery where rnb > 1)</where>
         </delete>
 
         <sql stripComments="true" dbms="!oracle">
             update connection c1 set
                 first_connexion_date = (select min(c2.first_connexion_date) from connection c2 where c2.sub=c1.sub group by c2.sub),
-                last_connexion_date =  (select max(c2.last_connexion_date) from connection c2 where c2.sub=c1.sub group by c2.sub),
-                connection_accepted =  (select connection_accepted from connection c2 where (c2.sub, c2.last_connexion_date) in (
+                last_connexion_date = (select max(c2.last_connexion_date) from connection c2 where c2.sub=c1.sub group by c2.sub),
+                connection_accepted = (select connection_accepted from connection c2 where (c2.sub, c2.last_connexion_date) in (
                     select c3.sub, max(c3.last_connexion_date) from connection c3 where c3.sub=c1.sub group by c3.sub) limit 1);
         </sql>
         <sql stripComments="true" dbms="oracle">
             --oracle use fetch instead of limit
             update connection c1 set
-            first_connexion_date = (select min(c2.first_connexion_date) from connection c2 where c2.sub=c1.sub group by c2.sub),
-            last_connexion_date =  (select max(c2.last_connexion_date) from connection c2 where c2.sub=c1.sub group by c2.sub),
-            connection_accepted =  (select connection_accepted from connection c2 where (c2.sub, c2.last_connexion_date) in (
-                select c3.sub, max(c3.last_connexion_date) from connection c3 where c3.sub=c1.sub group by c3.sub) FETCH FIRST 1 ROW ONLY);
+                first_connexion_date = (select min(c2.first_connexion_date) from connection c2 where c2.sub=c1.sub group by c2.sub),
+                last_connexion_date = (select max(c2.last_connexion_date) from connection c2 where c2.sub=c1.sub group by c2.sub),
+                connection_accepted = (select connection_accepted from connection c2 where (c2.sub, c2.last_connexion_date) in (
+                    select c3.sub, max(c3.last_connexion_date) from connection c3 where c3.sub=c1.sub group by c3.sub) FETCH FIRST 1 ROW ONLY);
         </sql>
         <delete tableName="connection">
             <where>id in (select id from (select row_number() over (partition by sub) as rnb, * from connection) subquery where rnb > 1)</where>
         </delete>
+
+        <rollback/><!--no rollback possible because delete, but no need as we just removed duplicate records-->
     </changeSet>
 
     <changeSet author="chuinetri" id="1704818243021-2">