fix(modification-creation): do not create modification when computation result is NOT_OK (#53)

* fix(modification-creation): do not create modification when computation result is NOT_OK

* fix: sonar issue

Author: TheMaskedTurtle

src/main/java/org/gridsuite/voltageinit/server/service/VoltageInitWorkerService.java

@@ -212,7 +212,7 @@ public Consumer<Message<String>> consumeRun() {
                 LOGGER.info("Just run in {}s", TimeUnit.NANOSECONDS.toSeconds(nanoTime - startTime.getAndSet(nanoTime)));
 
                 if (openReacResult != null) {  // result available
-                    UUID modificationsGroupUuid = networkModificationService.createVoltageInitModificationGroup(network, openReacResult);
+                    UUID modificationsGroupUuid = createModificationGroup(openReacResult, network);
                     Map<String, Bus> networkBuses = network.getBusView().getBusStream().collect(Collectors.toMap(Bus::getId, Function.identity()));
                     voltageInitObserver.observe("results.save", () ->
                         resultRepository.insert(resultContext.getResultUuid(), openReacResult, networkBuses, modificationsGroupUuid, openReacResult.getStatus().name()));
@@ -247,6 +247,12 @@ public Consumer<Message<String>> consumeRun() {
         };
     }
 
+    private UUID createModificationGroup(OpenReacResult openReacResult, Network network) {
+        return openReacResult.getStatus() == OpenReacStatus.OK ?
+            networkModificationService.createVoltageInitModificationGroup(network, openReacResult) :
+            null;
+    }
+
     @Bean
     public Consumer<Message<String>> consumeCancel() {
         return message -> cancelVoltageInitAsync(VoltageInitCancelContext.fromMessage(message));

src/test/java/org/gridsuite/voltageinit/server/VoltageInitControllerTest.java

@@ -77,8 +77,7 @@
 import static com.powsybl.network.store.model.NetworkStoreApi.VERSION;
 import static org.gridsuite.voltageinit.server.service.NotificationService.CANCEL_MESSAGE;
 import static org.gridsuite.voltageinit.server.service.NotificationService.HEADER_USER_ID;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.*;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.BDDMockito.given;
@@ -173,6 +172,12 @@ private OpenReacResult buildOpenReacResult() {
         return openReacResult;
     }
 
+    private OpenReacResult buildNokOpenReacResult() {
+        OpenReacAmplIOFiles openReacAmplIOFiles = new OpenReacAmplIOFiles(openReacParameters, network, false);
+        openReacResult = new OpenReacResult(OpenReacStatus.NOT_OK, openReacAmplIOFiles, INDICATORS);
+        return openReacResult;
+    }
+
     private VoltageInitParametersEntity buildVoltageInitParametersEntity() {
         return VoltageInitParametersInfos.builder()
             .voltageLimitsModification(List.of(VoltageLimitInfos.builder()
@@ -359,6 +364,37 @@ public void runTest() throws Exception {
 
     }
 
+    @Test
+    public void testReturnsResultAndDoesNotGenerateModificationIfResultNotOk() throws Exception {
+        try (MockedStatic<OpenReacRunner> openReacRunnerMockedStatic = Mockito.mockStatic(OpenReacRunner.class)) {
+            openReacRunnerMockedStatic.when(() -> OpenReacRunner.runAsync(eq(network), eq(VARIANT_2_ID), any(OpenReacParameters.class), any(OpenReacConfig.class), any(ComputationManager.class)))
+                .thenReturn(CompletableFutureTask.runAsync(this::buildNokOpenReacResult, ForkJoinPool.commonPool()));
+
+            MvcResult result = mockMvc.perform(post(
+                    "/" + VERSION + "/networks/{networkUuid}/run-and-save?receiver=me&variantId=" + VARIANT_2_ID, NETWORK_UUID)
+                    .header(HEADER_USER_ID, "userId"))
+                .andExpect(status().isOk())
+                .andExpect(content().contentType(MediaType.APPLICATION_JSON))
+                .andReturn();
+            assertEquals(RESULT_UUID, mapper.readValue(result.getResponse().getContentAsString(), UUID.class));
+
+            Message<byte[]> resultMessage = output.receive(TIMEOUT, "voltageinit.result");
+            assertEquals(RESULT_UUID.toString(), resultMessage.getHeaders().get("resultUuid"));
+            assertEquals("me", resultMessage.getHeaders().get("receiver"));
+
+            result = mockMvc.perform(get(
+                    "/" + VERSION + "/results/{resultUuid}", RESULT_UUID))
+                .andExpect(status().isOk())
+                .andExpect(content().contentType(MediaType.APPLICATION_JSON))
+                .andReturn();
+
+            VoltageInitResult resultDto = mapper.readValue(result.getResponse().getContentAsString(), VoltageInitResult.class);
+            assertEquals(RESULT_UUID, resultDto.getResultUuid());
+            assertEquals(INDICATORS, resultDto.getIndicators());
+            assertNull(resultDto.getModificationsGroupUuid());
+        }
+    }
+
     @Test
     public void runWrongNetworkTest() throws Exception {
         MvcResult result = mockMvc.perform(post(