Skip to content

Commit da4db9f

Browse files
committed
Introduce constants for test readability
1 parent c7481fe commit da4db9f

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

tests/table/test_init.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -795,21 +795,23 @@ def test_update_metadata_set_snapshot_ref(table_v2: Table) -> None:
795795

796796

797797
def test_update_remove_snapshots(table_v2: Table) -> None:
798+
REMOVE_SNAPSHOT = 3051729675574597004
799+
KEEP_SNAPSHOT = 3055729675574597004
798800
# assert fixture data to easily understand the test assumptions
799801
assert len(table_v2.metadata.snapshots) == 2
800802
assert len(table_v2.metadata.snapshot_log) == 2
801803
assert len(table_v2.metadata.refs) == 2
802-
update = RemoveSnapshotsUpdate(snapshot_ids=[3051729675574597004])
804+
update = RemoveSnapshotsUpdate(snapshot_ids=[REMOVE_SNAPSHOT])
803805
new_metadata = update_table_metadata(table_v2.metadata, (update,))
804806
assert len(new_metadata.snapshots) == 1
805-
assert new_metadata.snapshots[0].snapshot_id == 3055729675574597004
807+
assert new_metadata.snapshots[0].snapshot_id == KEEP_SNAPSHOT
806808
assert new_metadata.snapshots[0].parent_snapshot_id is None
807-
assert new_metadata.current_snapshot_id == 3055729675574597004
809+
assert new_metadata.current_snapshot_id == KEEP_SNAPSHOT
808810
assert new_metadata.last_updated_ms > table_v2.metadata.last_updated_ms
809811
assert len(new_metadata.snapshot_log) == 1
810-
assert new_metadata.snapshot_log[0].snapshot_id == 3055729675574597004
812+
assert new_metadata.snapshot_log[0].snapshot_id == KEEP_SNAPSHOT
811813
assert len(new_metadata.refs) == 1
812-
assert new_metadata.refs["main"].snapshot_id == 3055729675574597004
814+
assert new_metadata.refs["main"].snapshot_id == KEEP_SNAPSHOT
813815

814816

815817
def test_update_remove_snapshots_doesnt_exist(table_v2: Table) -> None:

0 commit comments

Comments
 (0)