1.7.4

Author: grimmdude

examples/notes-by-start-tick.js

@@ -14,12 +14,12 @@ track.addEvent([
 				startTick: 50
 			}),
 			new MidiWriter.NoteEvent({
-				pitch: 'G4',
+				pitch: ['G4', 'B4'],
 				duration: 'T50',
 				startTick: 100
 			}),
 			new MidiWriter.NoteEvent({
-				pitch: 'B4',
+				pitch: 'C5',
 				duration: 'T50',
 				startTick: 150
 			}),

package.json

@@ -1,6 +1,6 @@
 {
   "name": "midi-writer-js",
-  "version": "1.7.3",
+  "version": "1.7.4",
   "description": "A library providing an API for generating MIDI files.",
   "main": "build/index.js",
   "dependencies": {

src/note-events/note-event.js

@@ -99,10 +99,6 @@ class NoteEvent {
 				// Note off
 				this.pitch.forEach((p, i) => {
 					if (i == 0) {
-						// If this.startTick is set then don't use else block below.
-						// Using a duration:0 for non startTick events let's the buildData()
-						// method figure out it's own s
-
 						//noteOff = new NoteOffEvent({data: Utils.numberToVariableLength(tickDuration).concat(this.getNoteOffStatus(), Utils.getPitch(p), Utils.convertVelocity(this.velocity))});
 						var noteOffNew = new NoteOffEvent({
 							channel: this.channel,

src/track.js

@@ -7,7 +7,9 @@ import {InstrumentNameEvent} from './meta-events/instrument-name-event';
 import {KeySignatureEvent} from './meta-events/key-signature-event';
 import {LyricEvent} from './meta-events/lyric-event';
 import {MarkerEvent} from './meta-events/marker-event';
+import {NoteEvent} from './note-events/note-event';
 import {NoteOnEvent} from './note-events/note-on-event';
+import {NoteOffEvent} from './note-events/note-off-event';
 import {PitchBendEvent} from './meta-events/pitch-bend-event';
 import {TempoEvent} from './meta-events/tempo-event';
 import {TextEvent} from './meta-events/text-event';
@@ -43,7 +45,7 @@ class Track {
 	 */
 	addEvent(events, mapFunction) {
 		Utils.toArray(events).forEach((event, i) => {
-			if (event.type === 'note') {
+			if (event instanceof NoteEvent) {
 				// Handle map function if provided
 				if (typeof mapFunction === 'function') {
 					const properties = mapFunction(i, event);
@@ -101,7 +103,7 @@ class Track {
 
 		this.events.forEach((event, eventIndex) => {
 			// Build event & add to total tick duration
-			if (event.type === 'note-on' || event.type === 'note-off') {
+			if (event instanceof NoteOnEvent || event instanceof NoteOffEvent) {
 				this.data = this.data.concat(event.buildData(this).data);
 				this.tickPointer = event.tick;