Clenup unhandled exc

Author: gripep

drf_simple_api_errors/exception_handler.py

@@ -1,17 +1,19 @@
 import logging
+from typing import Optional
 
 from rest_framework import exceptions
 from rest_framework.response import Response
 from rest_framework.views import set_rollback
 
 from drf_simple_api_errors import formatter, handlers
-from drf_simple_api_errors.exceptions import ServerError
 from drf_simple_api_errors.types import ExceptionHandlerContext
 
 logger = logging.getLogger(__name__)
 
 
-def exception_handler(exc: Exception, context: ExceptionHandlerContext) -> Response:
+def exception_handler(
+    exc: Exception, context: ExceptionHandlerContext
+) -> Optional[Response]:
     """
     Custom exception handler for DRF.
 
@@ -44,10 +46,7 @@ def exception_handler(exc: Exception, context: ExceptionHandlerContext) -> Respo
     # This is because it's not good practice to expose the details of
     # unhandled exceptions to the client.
     if not isinstance(exc, exceptions.APIException):
-        # Raise a ServerError exception instead of returning None, because
-        # we can control the response format this way.
-        logger.info("Server error (500) from unexpected exception.", exc_info=True)
-        return ServerError
+        return None
 
     # Get the API response headers from the exception.
     headers = handlers.get_response_headers(exc)

drf_simple_api_errors/exceptions.py

@@ -4,7 +4,6 @@
 
 import pytest
 
-from drf_simple_api_errors import exceptions
 from drf_simple_api_errors.exception_handler import exception_handler
 from tests.utils import render_response
 
@@ -408,4 +407,4 @@ def test_unexpected_exception(self, mocker):
         """
         exc = Exception("Unexpected error")
         response = exception_handler(exc, mocker.Mock())
-        assert response is exceptions.ServerError
+        assert response is None