Allow injecting activities for debugging purposes

#245

Author: grishka

src/main/java/smithereen/SmithereenApplication.java

@@ -92,6 +92,7 @@
 import smithereen.routes.WellKnownRoutes;
 import smithereen.routes.admin.AdminAnnouncementsRoutes;
 import smithereen.routes.admin.AdminCustomCSSRoutes;
+import smithereen.routes.admin.AdminDebugRoutes;
 import smithereen.routes.admin.AdminEmailRulesRoutes;
 import smithereen.routes.admin.AdminFaspRoutes;
 import smithereen.routes.admin.AdminFederationRoutes;
@@ -535,6 +536,13 @@ public static void main(String[] args){
 						postRequiringPermissionWithCSRF("/update", UserRole.Permission.MANAGE_ANNOUNCEMENTS, AdminAnnouncementsRoutes::updateAnnouncement);
 					});
 				});
+
+				if(Config.DEBUG){
+					path("/debug", ()->{
+						getRequiringPermission("/injectActivity", UserRole.Permission.MANAGE_SERVER_SETTINGS, AdminDebugRoutes::injectActivity);
+						postRequiringPermissionWithCSRF("/injectActivity", UserRole.Permission.MANAGE_SERVER_SETTINGS, AdminDebugRoutes::doInjectActivity);
+					});
+				}
 			});
 		});
 

src/main/java/smithereen/routes/ActivityPubRoutes.java

@@ -830,14 +830,18 @@ public static Object undoLikeObject(Request req, Response resp){
 		return undo;
 	}
 
-	private static Object inbox(Request req, Response resp, Actor owner) throws SQLException{
-		ApplicationContext ctx=context(req);
+	private static Object inbox(Request req, Response resp, Actor owner){
 		if(req.headers("digest")!=null){
 			if(!verifyHttpDigest(req.headers("digest"), req.bodyAsBytes())){
 				throw new BadRequestException("Digest verification failed");
 			}
 		}
 		String body=req.body();
+		return dispatchActivity(body, req, resp, true);
+	}
+
+	public static Object dispatchActivity(String body, Request req, Response resp, boolean verifySignatures){
+		ApplicationContext ctx=context(req);
 		LOG.debug("Incoming activity: {}", body);
 		JsonObject rawActivity;
 		try{
@@ -907,19 +911,23 @@ else if(o!=null)
 		}
 
 		Actor httpSigOwner;
-		try{
-			httpSigOwner=ActivityPub.verifyHttpSignature(req, actor);
-		}catch(Exception x){
-			LOG.warn("Exception while verifying HTTP signature on {} from {}: {}", getActivityType(activity), actor.activityPubID, x.toString());
-			if(Config.DEBUG)
-				LOG.debug("", x);
-			throw new UserActionNotAllowedException(x);
+		if(verifySignatures){
+			try{
+				httpSigOwner=ActivityPub.verifyHttpSignature(req, actor);
+			}catch(Exception x){
+				LOG.warn("Exception while verifying HTTP signature on {} from {}: {}", getActivityType(activity), actor.activityPubID, x.toString());
+				if(Config.DEBUG)
+					LOG.debug("", x);
+				throw new UserActionNotAllowedException(x);
+			}
+		}else{
+			httpSigOwner=actor;
 		}
 
 		// if the activity has an LD-signature, verify that and allow any (cached) user to sign the HTTP signature
 		// if it does not, the owner of the HTTP signature must match the actor
 		boolean hasValidLDSignature=false;
-		if(rawActivity.has("signature")){
+		if(rawActivity.has("signature") && verifySignatures){
 			JsonObject sig=rawActivity.getAsJsonObject("signature");
 			try{
 				URI keyID=URI.create(sig.get("creator").getAsString());
@@ -1059,14 +1067,16 @@ else if(o!=null)
 			LOG.debug("Bad request", x);
 			resp.status(400);
 			return TextProcessor.escapeHTML(x.getMessage());
+		}catch(SQLException x){
+			throw new InternalServerErrorException(x);
 		}/*catch(Exception x){
 			LOG.warn("Exception while processing an incoming activity", x);
 			throw new BadRequestException(x.toString());
 		}*/
 		if(Config.DEBUG)
 			throw new BadRequestException("No handler found for activity type: "+getActivityType(activity));
 		else
-			LOG.error("Received and ignored an activity of an unsupported type {}: {}", getActivityType(activity), activity.asRootActivityPubObject(ctx, req.host()));
+			LOG.error("Received and ignored an activity of an unsupported type {}: {}", getActivityType(activity), body);
 		return "";
 	}
 

src/main/java/smithereen/routes/admin/AdminDebugRoutes.java

@@ -0,0 +1,31 @@
+package smithereen.routes.admin;
+
+import smithereen.ApplicationContext;
+import smithereen.model.Account;
+import smithereen.model.WebDeltaResponse;
+import smithereen.routes.ActivityPubRoutes;
+import smithereen.templates.RenderedTemplateResponse;
+import smithereen.text.TextProcessor;
+import spark.Request;
+import spark.Response;
+import spark.utils.StringUtils;
+
+import static smithereen.Utils.*;
+
+public class AdminDebugRoutes{
+	public static Object injectActivity(Request req, Response resp, Account self, ApplicationContext ctx){
+		return new RenderedTemplateResponse("admin_debug_inject_activity", req)
+				.pageTitle("Inject activity");
+	}
+
+	public static Object doInjectActivity(Request req, Response resp, Account self, ApplicationContext ctx){
+		String activity=req.queryParams("activity");
+		String result=ActivityPubRoutes.dispatchActivity(activity, req, resp, false).toString();
+		resp.status(200);
+		if(isAjax(req)){
+			return new WebDeltaResponse(resp)
+					.messageBox("Result", StringUtils.isEmpty(result) ? "Activity submitted, see server log for details." : TextProcessor.escapeHTML(result), lang(req).get("close"));
+		}
+		return result;
+	}
+}

src/main/java/smithereen/templates/Templates.java

@@ -199,6 +199,7 @@ public static void addGlobalParamsToTemplate(Request req, RenderedTemplateRespon
 				.with("serverName", Config.getServerDisplayName())
 				.with("serverDomain", Config.domain)
 				.with("serverVersion", BuildInfo.VERSION)
+				.with("isDebugMode", Config.DEBUG)
 				.with("langName", lang.name)
 				.with("isMobile", mobile)
 				.with("isAjax", Utils.isAjax(req))

src/main/resources/templates/common/admin_debug_inject_activity.twig

@@ -0,0 +1,12 @@
+{% extends "page" %}
+{% block content %}
+{% include "admin_debug_tabbar" with {'tab': 'injectActivity'} %}
+<div class="gray borderBottom singleColumn textByItself">
+	<p>Use this to inject activities as if they were posted to this server's inbox with a valid signature. Useful for debugging federation issues.</p>
+</div>
+<form class="singleColumn" action="/settings/admin/debug/injectActivity" method="post" data-ajax>
+	<textarea name="activity" placeholder="Activity JSON" style="width: 100%; font-family: monospace" id="activity"></textarea>
+	{% script %}autoSizeTextArea(ge('activity'));{% endscript %}
+	<input type="submit" value="Submit"/>
+</form>
+{% endblock %}

src/main/resources/templates/common/admin_debug_tabbar.twig

@@ -0,0 +1,3 @@
+<div class="secondaryTabBar">
+	<a href="/settings/admin/debug/injectActivity" class="{{ tab=='injectActivity' ? 'selected' : '' }}">Inject activity</a>
+</div>

src/main/resources/templates/common/left_menu.twig

@@ -23,6 +23,7 @@
 	{% if userPermissions.hasPermission('MANAGE_INVITES') and (serverSignupMode=='MANUAL_APPROVAL' or adminNotifications.signupRequestsCount>0) %}<li><a href="/settings/admin/signupRequests">{{ L('menu_signup_requests') }}{{ menuCounter(adminNotifications.signupRequestsCount, 'adminSignupRequests') }}</a></li>{% endif %}
 	{% if userPermissions.hasPermission('MANAGE_REPORTS') %}<li><a href="/settings/admin/reports">{{ L('menu_reports') }}{{ menuCounter(adminNotifications.openReportsCount, 'adminReports') }}</a></li>{% endif %}
 	{% if userPermissions.hasAnyPermission(['MANAGE_FEDERATION', 'MANAGE_BLOCKING_RULES']) %}<li><a href="/settings/admin/federation">{{ L('menu_access') }}</a></li>{% endif %}
+	{% if isDebugMode %}<li><a href="/settings/admin/debug/injectActivity">Debug tools</a></li>{% endif %}
 	{% endif %}
 	{% else %}
 	<li><a href="/account/login">{{ L('log_in') }}</a></li>