Bug fixed in StraightKeyParser + added tests

Author: Mateusz Gostański

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to `api-client` will be documented in this file
 
+## 3.1.1 - 2021-03-09
+
+- Bugs fixed
+
 ## 3.1.0 - 2021-03-09
 
 - Bug fixed in OAuthToken

src/Data/StraightKeyParser.php

@@ -22,7 +22,7 @@ public function parse(Collection $inputData): Collection
 
             foreach ($data as $key => $value) {
                 try {
-                    if (Carbon::createFromTimeString($value) == true) {
+                    if (is_string($value) && strlen($value) >= 27 && Carbon::createFromTimeString($value) == true) {
                         $data[$key] = Carbon::createFromTimeString($value);
                     }
                 } catch (\Exception $exception) {

tests/Data/StraightKeyParserTest.php

@@ -31,10 +31,17 @@ public function it_parsing_collection_of_arrays_to_collection_of_dtos()
             ]
         );
 
+        $this->basicAssertions($inputData);
+    }
+
+    protected function basicAssertions($inputData): Collection
+    {
         $returnedData = $this->obj->parse($inputData);
 
         $this->assertEquals(Collection::class, $returnedData::class);
         $this->assertCount(1, $returnedData);
+
+        return $returnedData;
     }
 
     /** @test */
@@ -52,9 +59,77 @@ public function it_skips_every_not_array_data()
             ]
         );
 
-        $returnedData = $this->obj->parse($inputData);
+        $this->basicAssertions($inputData);
+    }
 
-        $this->assertEquals(Collection::class, $returnedData::class);
-        $this->assertCount(1, $returnedData);
+    /** @test */
+    public function it_replaces_datetime_to_carbon()
+    {
+        $date = now();
+        $inputData = collect(
+            [
+                [
+                    'first' => 'first entry',
+                    'second' => 'second entry',
+                    'third' => 'third entry',
+                    'date' => $date->toISOString(),
+                ],
+            ]
+        );
+
+
+
+        $returnedData = $this->basicAssertions($inputData);
+
+        $this->assertEquals($date->timestamp, $returnedData->first()->date->timestamp);
+    }
+
+    /** @test */
+    public function it_do_not_replace_int_to_carbon()
+    {
+        $inputData = collect(
+            [
+                [
+                    'first' => 'first entry',
+                    'second' => 'second entry',
+                    'third' => 'third entry',
+                    'id' => 10987
+                ],
+            ]
+        );
+
+        $this->basicAssertions($inputData);
+    }
+
+    /** @test */
+    public function it_do_not_replace_some_numeric_strings_to_carbon()
+    {
+        $inputData = collect(
+            [
+                [
+                    'first' => 'first entry',
+                    'second' => 'second entry',
+                    'third' => '568845115895',
+                ],
+            ]
+        );
+
+        $this->basicAssertions($inputData);
+    }
+
+    /** @test */
+    public function it_safely_handles_strings_longer_than_27_charaters()
+    {
+        $inputData = collect(
+            [
+                [
+                    'first' => 'first entry is very long it could literally over 27 characters',
+                    'second' => 'second entry',
+                    'third' => '568845115895',
+                ],
+            ]
+        );
+
+        $this->basicAssertions($inputData);
     }
 }

tests/Helpers/ExampleDto.php

@@ -2,11 +2,14 @@
 
 namespace Grixu\ApiClient\Tests\Helpers;
 
+use Illuminate\Support\Carbon;
 use Spatie\DataTransferObject\DataTransferObject;
 
 class ExampleDto extends DataTransferObject
 {
     public string $first;
     public string $second;
     public string $third;
+    public ?Carbon $date;
+    public ?int $id;
 }