Closed
Conversation
Analysis of the fork and Athropic's API/CLI call works.
Author
|
Oops, should pay attention to the clicks. Sorry! |
2mawi2
pushed a commit
to 2mawi2/claude-code-action-extended
that referenced
this pull request
Jun 20, 2025
* Construct default Anthropic base URL for Bedrock ## Summary - Automatically constructs the Bedrock API endpoint URL using AWS_REGION when ANTHROPIC_BEDROCK_BASE_URL is not provided - Added test to document this behavior in test/validate-env.test.ts - Addresses issues anthropics#32 and anthropics#43 where users encountered 404 errors when using Bedrock integration without explicitly setting the base URL ## Background Users of AWS Bedrock integration were encountering 404 API errors when the ANTHROPIC_BEDROCK_BASE_URL was not explicitly set. This change ensures the URL is automatically constructed using the AWS_REGION, making the integration more user-friendly and preventing the confusing error messages reported in issues anthropics#32 and anthropics#43. ## Test Plan - Added test in test/validate-env.test.ts to document the behavior - Manual testing with AWS Bedrock integration * test: format test file with prettier to fix CI checks Ran `bun run format` to ensure proper code formatting and make CI checks pass. ## Test Plan - Verify formatting with `bun run format:check` - Ensure all CI checks pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis of the fork and Athropic's API/CLI call works.