init set

Author: grongierisc

src/iop/cls/IOP/Message.cls

@@ -127,30 +127,39 @@ Method SetValueAt(
 	pKey As %String = "") As %Status
 {
     Set tSC = $$$OK
-	Set tJSON = {}.%FromJSON(..json)
-	Set tPath = ..ConvertPath(pPropertyPath)
-
+    // if pAction is set, use jsonpath to set the value
+    // if pAction is clear, use jsonpath to remove the value
+    // if pAction is append, use jsonpath to append the value
+    // if pAction is insert, use jsonpath to insert the value, using pKey as the key
     Try {
-        If pAction = "set" {
-            Do tJSON.%Set(tPath, pValue)
+        // Convert pPropertyPath to a a jsonpath
+        Set tPath = ..ConvertPath(pPropertyPath)
+
+        Set pyjson = ##class(%SYS.Python).Import("json")
+        Set jp = ##class(%SYS.Python).Import("jsonpath_ng")
+        Set builtins = ##class(%SYS.Python).Builtins()
+
+        Set tJSON = pyjson.loads(..json)
+
+        Set parser = jp.parse(tPath)
+        if pAction = "set" {
+            Set tJSON = parser.update(tJSON, pValue)
         }
-        ElseIf pAction = "append" {
-            Set current = tJSON.%Get(tPath)
-            If current = "" {
-                Do tJSON.%Set(tPath, pValue)
-            }
-            Else {
-                Do tJSON.%Set(tPath, current _ pValue)
-            }
+        ElseIf pAction = "clear" {
+            Set tJSON = parser.remove(tJSON)
         }
-        ElseIf pAction = "remove" {
-            Do tJSON.%Remove(tPath)
+        ElseIf pAction = "append" {
+            Set tJSON = parser.append(tJSON, pValue)
         }
-        Else {
-            Set tSC = $$$ERROR($$$GeneralError, "Invalid action: " _ pAction)
+        ElseIf pAction = "insert" {
+            Set tJSON = parser.insert(tJSON, pValue, pKey)
         }
-    }
-    Catch ex {
+
+        Set tResult = pyjson.dumps(tJSON)
+        Set ..json = tResult
+        Set ..classname = ..DocType
+
+    } Catch ex {
         Set tSC = ex.AsStatus()
     }
     Return tSC

src/tests/test_iop_dtl.py

@@ -1,6 +1,7 @@
 import os
 import pytest
 import iris
+import json
 from iop._utils import _Utils
 from registerFilesIop.message import SimpleMessage, ComplexMessage
 
@@ -39,6 +40,16 @@ def test_get_value_at(iop_message, json_data, classname, path, expected):
     result = iop_message.GetValueAt(path)
     assert result == expected
 
+@pytest.mark.parametrize("json_data,path,value,action,key,expected_json", [
+    ('{"string":"Foo", "integer":42}', 'string', 'Bar', 'set', None, '{"string":"Bar", "integer":42}'),
+    (r'{"post":{"Title":"Foo"}}', 'post.Title', 'Bar', 'set', None, r'{"post":{"Title":"Bar"}}')
+])
+def test_set_value_at(iop_message, json_data, path, value, action, key, expected_json):
+    iop_message.json = json_data
+    iop_message.classname = 'foo'
+    iop_message.SetValueAt(value, path, action, key)
+    assert json.loads(iop_message.json) == json.loads(expected_json)
+
 @pytest.mark.parametrize("json_data,classname,transform_class,expected_value", [
     (
         '{"string":"Foo", "integer":42}',