Refactor FileOperation and FilterPostRoutingRule for improved functionality; enhance path handling, update message processing, and adjust PostMessage attributes for optional types.

Author: grongierisc

src/python/reddit/bo.py

@@ -14,9 +14,16 @@ class FileOperation(BusinessOperation):
     This operation receive a PostMessage and write down in the right company
     .txt all the important information and the time of the operation
     """
+
+    path = "/tmp"
+
     def on_init(self):
-        if hasattr(self,'path'):
-            os.chdir(self.path)
+        """
+        This method is called when the operation is created.
+        """
+
+        if not os.path.exists(self.path):
+            os.makedirs(self.path)
 
     def on_post_message(self, request: PostMessage):
         """
@@ -33,7 +40,7 @@ def on_post_message(self, request: PostMessage):
             ts = datetime.datetime.fromtimestamp(request.post.created_utc).__str__()
 
         line = ts+" : "+title+" : "+author+" : "+url
-        filename = request.found+".txt"
+        filename = (request.found or "default")+".txt"
 
 
         self.put_line(filename, line)
@@ -56,6 +63,7 @@ class FileOperationWithIrisAdapter(BusinessOperation):
     .txt all the important information and the time of the operation using the iris
     adapter EnsLib.File.OutboundAdapter
     """
+    @staticmethod
     def get_adapter_type():
         """
         Name of the registred Adapter

src/python/reddit/bp.py

@@ -30,12 +30,13 @@ def iris_to_python(self, request:'iris.dc.Demo.PostMessage'):
         return self.on_python_message(request)
 
     def on_python_message(self, request: PostMessage):
-        if 'dog'.upper() in request.post.selftext.upper():
-            request.to_email_address = '[email protected]'
-            request.found = 'Dog'
-        if 'cat'.upper() in request.post.selftext.upper():
-            request.to_email_address = '[email protected]'
-            request.found = 'Cat'
+        if request.post and request.post.selftext:
+            if 'dog'.upper() in request.post.selftext.upper():
+                request.to_email_address = '[email protected]'
+                request.found = 'Dog'
+            if 'cat'.upper() in request.post.selftext.upper():
+                request.to_email_address = '[email protected]'
+                request.found = 'Cat'
 
         if request.found is not None:
             rsp = self.send_request_sync(self.target,request)

src/python/reddit/bs.py

@@ -1,8 +1,10 @@
 from iop import BusinessService
 
+from typing import Optional
 import json
 import requests
 
+
 from message import PostMessage
 from obj import PostClass
 
@@ -12,6 +14,11 @@ class RedditService(BusinessService):
     seconds, use requests to fetch self.limit posts as data from the reddit
     API before calling the FilterPostRoutingRule process.
     """
+    feed = "/new/"
+    limit = "5"
+    target = "Python.FilterPostRoutingRule"
+
+    @staticmethod
     def get_adapter_type():
         """
         Name of the registred Adapter
@@ -22,21 +29,12 @@ def on_init(self):
         """
         This method is called when the service is created.
         """
-        
-        if not hasattr(self,'feed'):
-            self.feed = "/new/"
-        
-        if not hasattr(self,'limit'):
-            raise TypeError('no limit field')
-
-        if not hasattr(self,'target'):
-            self.target = "Python.FilterPostRoutingRule"
-        
-        self.last_post_name = ""
-        
-        return 1
-
-    def on_process_input(self,request):
+        if self.limit is None:
+            self.limit = "5"
+
+        self.last_post_name = "t3_tjflyd"  # This is the last post name to start from, it should be updated after the first fetch.
+
+    def on_process_input(self,message_input):
         """
         This method is called every 5 seconds by the Ens.InboundAdapter.
         """
@@ -47,7 +45,7 @@ def on_process_input(self,request):
             msg.post = post
             self.send_request_sync(self.target,msg)
 
-    def on_task(self) -> PostClass:
+    def on_task(self) -> Optional[PostClass]:
         """
         This method is called by on_process_input to fetch the data from the
         reddit API.

src/python/reddit/message.py

@@ -1,12 +1,11 @@
 from iop import Message
-
+from typing import Optional
 from dataclasses import dataclass
-
 from obj import PostClass
 
 @dataclass
 class PostMessage(Message):
 
-    post:PostClass = None
-    to_email_address:str = None
-    found:str = None
+    post:Optional[PostClass] = None
+    to_email_address:Optional[str] = None
+    found:Optional[str] = None

src/python/reddit/settings.py

@@ -1,6 +1,8 @@
+import os
+
 import bp
-from bo import *
-from bs import *
+from bo import FileOperation, FileOperationWithIrisAdapter
+from bs import RedditService
 
 CLASSES = {
     'Python.RedditService': RedditService,
@@ -29,11 +31,6 @@
                 "@LogTraceEvents": "true",
                 "@Schedule": "",
                 "Setting": [
-                    {
-                        "@Target": "Host",
-                        "@Name": "%settings",
-                        "#text": "path=/tmp"
-                    },
                     {
                         "@Target": "Host",
                         "@Name": "%enable",
@@ -55,14 +52,7 @@
                 "@Foreground": "false",
                 "@Comment": "",
                 "@LogTraceEvents": "false",
-                "@Schedule": "",
-                "Setting": [
-                    {
-                        "@Target": "Host",
-                        "@Name": "%settings",
-                        "#text": "limit=10\nother<10"
-                    }
-                ]
+                "@Schedule": ""
             },
             {
                 "@Name": "Python.FilterPostRoutingRule",