Print a warning about SecurityManager being deprecated#289
Closed
keeganwitt wants to merge 1 commit intomasterfrom
Closed
Print a warning about SecurityManager being deprecated#289keeganwitt wants to merge 1 commit intomasterfrom
keeganwitt wants to merge 1 commit intomasterfrom
Conversation
keeganwitt
force-pushed
the
print_warning_about_SecurityManager
branch
from
f480905 to
5a972af
Compare
keeganwitt
force-pushed
the
print_warning_about_SecurityManager
branch
from
5a972af to
6b53394
Compare
Contributor
|
This PR has too much noise on unrelated lines. I cannot even see the actual change. |
Contributor
|
What about #287 ? |
Member
Author
Oops. Thank you for the reminder. I think I might have had local commits started and didn't see you opened a PR about that same time before opening this one. That would be the better solution. We probably should move forward with that one and not this one. |
Member
Author
|
Moved the unrelated changes into a separate PR: #290. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.