Skip to content

Commit 5a3c63b

Browse files
authored
Merge pull request #111 from groovy/noble
Upgrade to Ubuntu Noble
2 parents b611b20 + 95075e3 commit 5a3c63b

File tree

4 files changed

+23
-26
lines changed

4 files changed

+23
-26
lines changed

.github/workflows/ci.yaml

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -17,29 +17,22 @@ jobs:
1717
runs-on: ubuntu-latest
1818
strategy:
1919
matrix:
20-
version:
21-
- 8-jdk-jammy
22-
- 11-jdk-jammy
23-
- 11-jdk-alpine
24-
- 17-jdk-jammy
25-
- 17-jdk-alpine
26-
- 21-jdk-jammy
27-
- 21-jdk-alpine
20+
directory:
21+
- jdk8
22+
- jdk11
23+
- jdk17
24+
- jdk21
2825
steps:
2926
- name: checkout
30-
uses: actions/checkout@v2
27+
uses: actions/checkout@v4
3128
- name: build
32-
env:
33-
version: ${{ matrix.version }}
3429
run: |
35-
directory=$(echo "jdk${version}" | sed 's/-jdk//' | sed 's/-jammy//')
36-
cd "${directory}"
37-
docker pull "eclipse-temurin:${version}"
38-
docker build --tag "groovy:${version}" .
30+
cd "${{ matrix.directory }}"
31+
grep "FROM " Dockerfile | cut -d' ' -f2 | xargs -I{} docker pull {}
32+
docker build --tag "groovy:${{ matrix.directory }}" .
3933
- name: test
4034
env:
41-
version: ${{ matrix.version }}
4235
expectedGroovyVersion: 4.0.27
4336
run: |
4437
cd test
45-
./run.sh "groovy:${version}" "${expectedGroovyVersion}"
38+
./run.sh "groovy:${{ matrix.directory }}" "${expectedGroovyVersion}"

generate-stackbrew-library.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ for dir in "${directories[@]}"; do
104104

105105
fromTag="${from##*:}"
106106
suite="${fromTag%-jdk}"
107-
suite="${suite##*-}" # "noble", "jammy", "al2023", etc
107+
suite="${suite##*-}" # "noble", "jammy", etc
108108
jdk="${dir%%-*}" # "jdk8", etc
109109

110110
# identify image "variant" so we can assign tags based on variant

jdk17/Dockerfile

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
1-
FROM eclipse-temurin:17-jdk-jammy
1+
FROM eclipse-temurin:17-jdk-noble
22

33
CMD ["groovysh"]
44

55
ENV GROOVY_HOME=/opt/groovy
66

77
RUN set -o errexit -o nounset \
8-
&& echo "Adding groovy user and group" \
9-
&& groupadd --system --gid 1000 groovy \
10-
&& useradd --system --gid groovy --uid 1000 --shell /bin/bash --create-home groovy \
8+
&& echo "Renaming ubuntu user and group to groovy" \
9+
&& groupmod --new-name groovy ubuntu \
10+
&& mkdir /home/groovy \
11+
&& usermod --login groovy --home /home/groovy --groups groovy ubuntu \
12+
&& chown groovy /home/groovy \
1113
&& mkdir --parents /home/groovy/.groovy/grapes \
1214
&& chown --recursive groovy:groovy /home/groovy \
1315
&& chmod --recursive 1777 /home/groovy \

jdk21/Dockerfile

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
1-
FROM eclipse-temurin:21-jdk-jammy
1+
FROM eclipse-temurin:21-jdk-noble
22

33
CMD ["groovysh"]
44

55
ENV GROOVY_HOME=/opt/groovy
66

77
RUN set -o errexit -o nounset \
8-
&& echo "Adding groovy user and group" \
9-
&& groupadd --system --gid 1000 groovy \
10-
&& useradd --system --gid groovy --uid 1000 --shell /bin/bash --create-home groovy \
8+
&& echo "Renaming ubuntu user and group to groovy" \
9+
&& groupmod --new-name groovy ubuntu \
10+
&& mkdir /home/groovy \
11+
&& usermod --login groovy --home /home/groovy --groups groovy ubuntu \
12+
&& chown groovy /home/groovy \
1113
&& mkdir --parents /home/groovy/.groovy/grapes \
1214
&& chown --recursive groovy:groovy /home/groovy \
1315
&& chmod --recursive 1777 /home/groovy \

0 commit comments

Comments
 (0)