Skip to content

Commit 2b206bb

Browse files
author
brandon
committed
ah the linter
1 parent 61d9173 commit 2b206bb

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

src/groundlight/experimental_api.py

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -953,9 +953,10 @@ def create_multiclass_detector( # noqa: PLR0913 # pylint: disable=too-many-argu
953953
obj = self.detectors_api.create_detector(detector_creation_input, _request_timeout=DEFAULT_REQUEST_TIMEOUT)
954954
return Detector.parse_obj(obj.to_dict())
955955

956-
def _download_mlbinary_url(self, detector: Union[str, Detector]) -> str:
956+
def _download_mlbinary_url(self, detector: Union[str, Detector]) -> EdgeModelInfo:
957957
"""
958-
Gets a temporary presigned URL to download the model binaries for the given detector, along with relevant metadata
958+
Gets a temporary presigned URL to download the model binaries for the given detector, along
959+
with relevant metadata
959960
"""
960961
if isinstance(detector, Detector):
961962
detector = detector.id
@@ -983,14 +984,20 @@ def download_mlbinary(self, detector: Union[str, Detector], output_dir: str) ->
983984
def _download_and_save(url: str, output_path: str) -> None:
984985
try:
985986
response = requests.get(url, timeout=10)
986-
except:
987-
raise GroundlightClientError(f"Failed to retrieve data from {url}.")
987+
except Exception as e:
988+
raise GroundlightClientError(f"Failed to retrieve data from {url}.") from e
988989
with open(output_path, "wb") as file:
989990
file.write(response.content)
990991
return response.content
991992

992993
if isinstance(detector, Detector):
993994
detector = detector.id
994995
edge_model_info = self._download_mlbinary_url(detector)
995-
_download_and_save(edge_model_info.model_binary_url, Path(output_dir) / edge_model_info.model_binary_id)
996-
_download_and_save(edge_model_info.oodd_model_binary_url, Path(output_dir) / edge_model_info.oodd_model_binary_id)
996+
_download_and_save(
997+
edge_model_info.model_binary_url,
998+
Path(output_dir) / edge_model_info.model_binary_id
999+
)
1000+
_download_and_save(
1001+
edge_model_info.oodd_model_binary_url,
1002+
Path(output_dir) / edge_model_info.oodd_model_binary_id
1003+
)

0 commit comments

Comments
 (0)