Skip to content

Commit 9b074df

Browse files
brandon-wadaAuto-format Bot
andauthored
Re enable improvement test (#129)
* temporarily disable tests * Automatically reformatting code * comment out whole test * use pytest skip rather than comment * Open the gates! Turn the tests back on! * fix ask method quality * overwrite merge overwriting fix * fix other line --------- Co-authored-by: Auto-format Bot <autoformatbot@groundlight.ai>
1 parent a341333 commit 9b074df

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

test/integration/test_groundlight.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,6 @@ def test_submit_numpy_image(gl: Groundlight, detector: Detector):
456456
assert is_valid_display_result(_image_query.result)
457457

458458

459-
@pytest.mark.skip(reason="Detector improvement is incredibly flaky")
460459
@pytest.mark.skipif(MISSING_PIL, reason="Needs pillow") # type: ignore
461460
def test_detector_improvement(gl: Groundlight):
462461
# test that we get confidence improvement after sending images in
@@ -526,7 +525,6 @@ def submit_noisy_image(image, label=None):
526525
), f"The detector {detector} quality has not improved after two minutes q.v. {new_dog_query}, {new_cat_query}"
527526

528527

529-
@pytest.mark.skip(reason="Detector improvement is incredibly flaky")
530528
def test_ask_method_quality(gl: Groundlight, detector: Detector):
531529
# asks for some level of quality on how fast ask_ml is and that we will get a confident result from ask_confident
532530
fast_always_yes_iq = gl.ask_ml(detector=detector.id, image="test/assets/dog.jpeg", wait=0)
@@ -537,7 +535,7 @@ def test_ask_method_quality(gl: Groundlight, detector: Detector):
537535
fast_iq = gl.ask_ml(detector=detector.id, image="test/assets/dog.jpeg", wait=0)
538536
assert iq_is_answered(fast_iq)
539537
confident_iq = gl.ask_confident(detector=detector.id, image="test/assets/dog.jpeg", wait=180)
540-
assert confident_iq.result.confidence > IQ_IMPROVEMENT_THRESHOLD
538+
assert confident_iq.result.confidence is None or (confident_iq.result.confidence > IQ_IMPROVEMENT_THRESHOLD)
541539

542540

543541
def test_start_inspection(gl: Groundlight):

0 commit comments

Comments
 (0)