responding to PR feedback

Author: timmarkhuff

src/groundlight/edge/__init__.py

@@ -1,5 +1,4 @@
 from .config import (
-    ConfigBase,
     DEFAULT,
     DISABLED,
     EDGE_ANSWERS_WITH_ESCALATION,
@@ -16,7 +15,6 @@
     "DISABLED",
     "EDGE_ANSWERS_WITH_ESCALATION",
     "NO_CLOUD",
-    "ConfigBase",
     "DetectorsConfig",
     "DetectorConfig",
     "EdgeEndpointConfig",

src/groundlight/edge/config.py

@@ -156,13 +156,8 @@ def add_detector(self, detector: Union[str, Detector], edge_inference_config: In
         self.detectors.append(DetectorConfig(detector_id=detector_id, edge_inference_config=edge_inference_config.name))
 
     def to_payload(self) -> dict[str, Any]:
-        """Return detector payload used by edge-endpoint config HTTP APIs."""
-        return {
-            "edge_inference_configs": {
-                name: config.model_dump() for name, config in self.edge_inference_configs.items()
-            },
-            "detectors": [detector.model_dump() for detector in self.detectors],
-        }
+        """Return this config as a payload dictionary."""
+        return self.model_dump()
 
 
 class DetectorsConfig(ConfigBase):
@@ -199,16 +194,6 @@ def from_yaml(
         parsed = yaml.safe_load(yaml_text) or {}
         return cls.model_validate(parsed)
 
-    def to_payload(self) -> dict[str, Any]:
-        """Return the full edge-endpoint payload shape."""
-        return {
-            "global_config": self.global_config.model_dump(),
-            "edge_inference_configs": {
-                name: config.model_dump() for name, config in self.edge_inference_configs.items()
-            },
-            "detectors": [detector.model_dump() for detector in self.detectors],
-        }
-
     @classmethod
     def from_payload(cls, payload: dict[str, Any]) -> "EdgeEndpointConfig":
         """Construct an EdgeEndpointConfig from a payload dictionary."""

test/unit/test_edge_config.py

@@ -269,6 +269,21 @@ def test_edge_endpoint_config_from_payload_round_trip():
     assert reconstructed == config
 
 
+def test_edge_endpoint_config_from_payload_accepts_literal_payload():
+    """Constructs EdgeEndpointConfig from a literal payload dictionary."""
+    payload = {
+        "global_config": {"refresh_rate": 15.0},
+        "edge_inference_configs": {"default": {"enabled": True}},
+        "detectors": [{"detector_id": "det_1", "edge_inference_config": "default"}],
+    }
+
+    config = EdgeEndpointConfig.from_payload(payload)
+
+    assert config.global_config.refresh_rate == 15.0
+    assert config.edge_inference_configs["default"].name == "default"
+    assert [detector.detector_id for detector in config.detectors] == ["det_1"]
+
+
 def test_inference_config_validation_errors():
     """Raises on invalid inference config flag combinations and values."""
     with pytest.raises(ValueError, match="disable_cloud_escalation"):