Fix HTTP body parsing bug in HostAPIService and use dynamic bundle IDs

This commit fixes a critical bug where remote exec and other POST endpoints
were failing, and makes GhostTools more resilient to bundle ID changes.

**HTTP Body Parsing Bug Fix (HostAPIService.swift)**:
- Fixed parseHTTPRequest to search for \r\n\r\n delimiter in raw bytes instead
  of UTF-8 string
- Previous code used string character offsets as byte offsets into rawData,
  causing misalignment that included header data in the body
- This caused JSON parsing to fail with errors like "Need command" or
  "Need action" even when valid JSON was sent
- Fix: Use Data.range(of:) to search directly in rawData bytes

**Dynamic Bundle ID (GhostTools)**:
- Added bundleId computed property using Bundle.main.bundleIdentifier
- Replaced all hardcoded bundle ID references with dynamic property
- Affects: launch agent paths, launchctl commands, dispatch queue labels
- Makes code resilient to future bundle ID changes

**Enhanced Launch Agent Cleanup (GhostTools)**:
- Added -w flag to launchctl unload to persist disabled state
- Capture and log stderr from unload command
- Better error handling with try/catch for plist removal
- More detailed migration logging

Verified with: vmctl remote exec /bin/ls /Applications

Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com>

Author: groundwater

GhostTools/Sources/GhostTools/App.swift

@@ -38,8 +38,11 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
     private var updateTimer: Timer?
     private var lockFileHandle: FileHandle?
     // Use bundle ID from Info.plist, fallback to hardcoded for compatibility
+    private var bundleId: String {
+        Bundle.main.bundleIdentifier ?? "com.yellowgreenfruit.com.ghostvm.guest-tools"
+    }
+
     private lazy var lockFilePath: String = {
-        let bundleId = Bundle.main.bundleIdentifier ?? "com.yellowgreenfruit.com.ghostvm.guest-tools"
         return NSTemporaryDirectory() + bundleId + ".lock"
     }()
 
@@ -507,7 +510,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
         print("[GhostTools] Checking launch agent installation...")
         let launchAgentsDir = FileManager.default.homeDirectoryForCurrentUser
             .appendingPathComponent("Library/LaunchAgents")
-        let plistPath = launchAgentsDir.appendingPathComponent("com.yellowgreenfruit.com.ghostvm.guest-tools.plist")
+        let plistPath = launchAgentsDir.appendingPathComponent("\(bundleId).plist")
 
         // MIGRATION: Remove old launch agents with old bundle IDs
         let oldPlistPaths = [
@@ -517,19 +520,35 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
 
         for oldPlistPath in oldPlistPaths {
             if FileManager.default.fileExists(atPath: oldPlistPath.path) {
-                print("[GhostTools] Found old launch agent at \(oldPlistPath.lastPathComponent), removing...")
+                print("[GhostTools] === MIGRATION: Removing old launch agent ===")
+                print("[GhostTools] Old plist: \(oldPlistPath.path)")
 
-                // Unload old launch agent
+                // Unload from launchctl (ignore errors - may not be loaded)
                 let unloadOld = Process()
                 unloadOld.executableURL = URL(fileURLWithPath: "/bin/launchctl")
-                unloadOld.arguments = ["unload", oldPlistPath.path]
+                unloadOld.arguments = ["unload", "-w", oldPlistPath.path]  // Add -w to write disabled state
+
+                let errorPipe = Pipe()
+                unloadOld.standardError = errorPipe
+
                 try? unloadOld.run()
                 unloadOld.waitUntilExit()
-                print("[GhostTools] Unloaded old launch agent (exit status: \(unloadOld.terminationStatus))")
 
-                // Remove old plist
-                try? FileManager.default.removeItem(at: oldPlistPath)
-                print("[GhostTools] Removed old launch agent plist")
+                let errorData = errorPipe.fileHandleForReading.readDataToEndOfFile()
+                let errorStr = String(data: errorData, encoding: .utf8) ?? ""
+
+                print("[GhostTools] launchctl unload exit status: \(unloadOld.terminationStatus)")
+                if !errorStr.isEmpty {
+                    print("[GhostTools] launchctl unload stderr: \(errorStr)")
+                }
+
+                // Force remove the file
+                do {
+                    try FileManager.default.removeItem(at: oldPlistPath)
+                    print("[GhostTools] Removed old plist successfully")
+                } catch {
+                    print("[GhostTools] Failed to remove old plist: \(error)")
+                }
             }
         }
 
@@ -547,7 +566,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
                 // Verify it's loaded in launchd
                 let launchctlList = Process()
                 launchctlList.executableURL = URL(fileURLWithPath: "/bin/launchctl")
-                launchctlList.arguments = ["list", "com.yellowgreenfruit.com.ghostvm.guest-tools"]
+                launchctlList.arguments = ["list", bundleId]
 
                 let outputPipe = Pipe()
                 launchctlList.standardOutput = outputPipe
@@ -582,7 +601,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
 
         // Create the plist content - always point to /Applications
         let plistContent: [String: Any] = [
-            "Label": "com.yellowgreenfruit.com.ghostvm.guest-tools",
+            "Label": bundleId,
             "ProgramArguments": [executablePath],
             "RunAtLoad": true,
             "KeepAlive": false

GhostTools/Sources/GhostTools/Server/EventPushServer.swift

@@ -62,7 +62,7 @@ final class EventPushServer: @unchecked Sendable {
     private let clientLock = NSLock()
 
     /// Serial queue for writes (preserves NDJSON line ordering)
-    private let writeQueue = DispatchQueue(label: "com.yellowgreenfruit.com.ghostvm.guest-tools.eventpush.write")
+    private let writeQueue = DispatchQueue(label: "\(Bundle.main.bundleIdentifier ?? "com.yellowgreenfruit.com.ghostvm.guest-tools").eventpush.write")
 
     /// Called on main thread when a new host client connects.
     var onClientConnected: (() -> Void)?

GhostVMHelper/HostAPIService.swift

@@ -181,10 +181,12 @@ final class HostAPIService {
         let path = parts.count > 1 ? parts[1] : "/"
 
         // Extract body after \r\n\r\n
-        if let range = str.range(of: "\r\n\r\n") {
-            let headerEndIndex = str.distance(from: str.startIndex, to: range.upperBound)
+        // IMPORTANT: Search in raw bytes, not the UTF-8 string, to avoid character/byte offset misalignment
+        let delimiter = Data([0x0d, 0x0a, 0x0d, 0x0a]) // \r\n\r\n
+        if let delimiterRange = rawData.range(of: delimiter) {
+            let headerEndIndex = delimiterRange.upperBound
             if rawData.count > headerEndIndex {
-                return (method, path, rawData[headerEndIndex...])
+                return (method, path, Data(rawData[headerEndIndex...]))
             }
         }
         return (method, path, nil)
@@ -449,20 +451,9 @@ final class HostAPIService {
 
             // Exec
             if cleanPath == "/api/v1/exec" && method == "POST" {
-                // Debug logging
-                if let body = body {
-                    print("[HostAPIService] Exec body size: \(body.count) bytes")
-                    if let bodyStr = String(data: body, encoding: .utf8) {
-                        print("[HostAPIService] Exec body: \(bodyStr)")
-                    }
-                } else {
-                    print("[HostAPIService] Exec body is nil!")
-                }
-
                 guard let body = body,
                       let json = try? JSONSerialization.jsonObject(with: body) as? [String: Any],
                       let command = json["command"] as? String else {
-                    print("[HostAPIService] Failed to parse exec command")
                     return .error(400, message: "Need command")
                 }
                 let resp = try await client.exec(