Add comment re: sorting and binary search

akshayjshah · akshayjshah · commit 21bacae4fa82 · 2024-05-26T21:07:05.000-07:00
Signed-off-by: Akshay Shah &lt;akshay@akshayshah.org&gt;
diff --git a/interceptors/protovalidate/options.go b/interceptors/protovalidate/options.go
@@ -43,6 +43,7 @@ func WithIgnoreMessages(msgs ...protoreflect.MessageType) Option {
 }
 
 func (o *options) shouldIgnoreMessage(fqn protoreflect.FullName) bool {
+	// Names are sorted in WithIgnoreMessages, so we can use binary search.
 	_, found := slices.BinarySearch(o.ignoreMessages, fqn)
 	return found
 }

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ func WithIgnoreMessages(msgs ...protoreflect.MessageType) Option {`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`func (o *options) shouldIgnoreMessage(fqn protoreflect.FullName) bool {`
	`46`	`+ // Names are sorted in WithIgnoreMessages, so we can use binary search.`
`46`	`47`	`_, found := slices.BinarySearch(o.ignoreMessages, fqn)`
`47`	`48`	`return found`
`48`	`49`	`}`