Skip to content

Commit 72478fa

Browse files
authored
Update provider/kit (#490)
* Fix providers/kit for latest v2 * providers/kit: Fix linting
1 parent e4a6915 commit 72478fa

File tree

3 files changed

+382
-39
lines changed

3 files changed

+382
-39
lines changed

providers/kit/examples_test.go

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ package kit_test
66
import (
77
"context"
88
"testing"
9+
"time"
910

1011
"github.com/go-kit/log"
1112
"github.com/grpc-ecosystem/go-grpc-middleware/providers/kit/v2"
1213
"google.golang.org/grpc"
1314

1415
"github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/logging"
15-
"github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/tags"
1616
)
1717

1818
var (
@@ -51,7 +51,6 @@ func Example_initializationWithDurationFieldOverride() {
5151
logging.UnaryServerInterceptor(kit.InterceptorLogger(logger), opts...),
5252
),
5353
grpc.ChainStreamInterceptor(
54-
tags.StreamServerInterceptor(),
5554
logging.StreamServerInterceptor(kit.InterceptorLogger(logger), opts...),
5655
),
5756
)
@@ -63,11 +62,9 @@ func Example_initializationWithCodeGenRequestFieldExtractor() {
6362
// Create a server, make sure we put the tags context before everything else.
6463
_ = grpc.NewServer(
6564
grpc.ChainUnaryInterceptor(
66-
tags.UnaryServerInterceptor(tags.WithFieldExtractor(tags.CodeGenRequestFieldExtractor)),
6765
logging.UnaryServerInterceptor(kit.InterceptorLogger(logger)),
6866
),
6967
grpc.ChainStreamInterceptor(
70-
tags.StreamServerInterceptor(tags.WithFieldExtractor(tags.CodeGenRequestFieldExtractor)),
7168
logging.StreamServerInterceptor(kit.InterceptorLogger(logger)),
7269
),
7370
)
@@ -78,7 +75,7 @@ func ExampleWithDecider() {
7875
logger := log.NewNopLogger()
7976
// Shared options for the logger, with a custom decider that log everything except successful calls from "/blah.foo.healthcheck/Check" method.
8077
opts := []logging.Option{
81-
logging.WithDecider(func(methodFullName string) logging.Decision {
78+
logging.WithDecider(func(methodFullName string, err error) logging.Decision {
8279
// will not log gRPC calls if it was a call to healthcheck and no error was raised
8380
if methodFullName == "/blah.foo.healthcheck/Check" {
8481
return logging.NoLogCall
@@ -90,11 +87,9 @@ func ExampleWithDecider() {
9087
// Create a server, make sure we put the tags context before everything else.
9188
_ = []grpc.ServerOption{
9289
grpc.ChainUnaryInterceptor(
93-
tags.UnaryServerInterceptor(),
9490
logging.UnaryServerInterceptor(kit.InterceptorLogger(logger), opts...),
9591
),
9692
grpc.ChainStreamInterceptor(
97-
tags.StreamServerInterceptor(),
9893
logging.StreamServerInterceptor(kit.InterceptorLogger(logger), opts...),
9994
),
10095
}
@@ -104,21 +99,21 @@ func ExampleServerPayloadLoggingDecider() {
10499
// Logger is used, allowing pre-definition of certain fields by the user.
105100
logger := log.NewNopLogger()
106101
// Expect payload from "/blah.foo.healthcheck/Check" call to be logged.
107-
payloadDecider := func(ctx context.Context, fullMethodName string, servingObject interface{}) bool {
108-
return fullMethodName == "/blah.foo.healthcheck/Check"
102+
payloadDecider := func(ctx context.Context, fullMethodName string, servingObject interface{}) logging.PayloadDecision {
103+
// return fullMethodName == "/blah.foo.healthcheck/Check"
104+
// TODO Fix
105+
return 0
109106
}
110107

111108
// Create a server, make sure we put the tags context before everything else.
112109
_ = []grpc.ServerOption{
113110
grpc.ChainUnaryInterceptor(
114-
tags.UnaryServerInterceptor(),
115111
logging.UnaryServerInterceptor(kit.InterceptorLogger(logger)),
116-
logging.PayloadUnaryServerInterceptor(kit.InterceptorLogger(logger), payloadDecider),
112+
logging.PayloadUnaryServerInterceptor(kit.InterceptorLogger(logger), payloadDecider, time.RFC3339Nano),
117113
),
118114
grpc.ChainStreamInterceptor(
119-
tags.StreamServerInterceptor(),
120115
logging.StreamServerInterceptor(kit.InterceptorLogger(logger)),
121-
logging.PayloadStreamServerInterceptor(kit.InterceptorLogger(logger), payloadDecider),
116+
logging.PayloadStreamServerInterceptor(kit.InterceptorLogger(logger), payloadDecider, time.RFC3339Nano),
122117
),
123118
}
124119
}

providers/kit/go.mod

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@ module github.com/grpc-ecosystem/go-grpc-middleware/providers/kit/v2
33
go 1.14
44

55
require (
6-
github.com/go-kit/log v0.1.0
6+
github.com/go-kit/log v0.2.0
77
github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.0.0-rc.2.0.20201002093600-73cf2ae9d891
8-
google.golang.org/grpc v1.30.0
8+
golang.org/x/net v0.0.0-20220401154927-543a649e0bdd // indirect
9+
golang.org/x/sys v0.0.0-20220330033206-e17cdc41300f // indirect
10+
google.golang.org/genproto v0.0.0-20220401170504-314d38edb7de // indirect
11+
google.golang.org/grpc v1.45.0
912
)
13+
14+
replace github.com/grpc-ecosystem/go-grpc-middleware/v2 => ../..

0 commit comments

Comments
 (0)