@@ -6,13 +6,13 @@ package kit_test
6
6
import (
7
7
"context"
8
8
"testing"
9
+ "time"
9
10
10
11
"github.com/go-kit/log"
11
12
"github.com/grpc-ecosystem/go-grpc-middleware/providers/kit/v2"
12
13
"google.golang.org/grpc"
13
14
14
15
"github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/logging"
15
- "github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/tags"
16
16
)
17
17
18
18
var (
@@ -51,7 +51,6 @@ func Example_initializationWithDurationFieldOverride() {
51
51
logging .UnaryServerInterceptor (kit .InterceptorLogger (logger ), opts ... ),
52
52
),
53
53
grpc .ChainStreamInterceptor (
54
- tags .StreamServerInterceptor (),
55
54
logging .StreamServerInterceptor (kit .InterceptorLogger (logger ), opts ... ),
56
55
),
57
56
)
@@ -63,11 +62,9 @@ func Example_initializationWithCodeGenRequestFieldExtractor() {
63
62
// Create a server, make sure we put the tags context before everything else.
64
63
_ = grpc .NewServer (
65
64
grpc .ChainUnaryInterceptor (
66
- tags .UnaryServerInterceptor (tags .WithFieldExtractor (tags .CodeGenRequestFieldExtractor )),
67
65
logging .UnaryServerInterceptor (kit .InterceptorLogger (logger )),
68
66
),
69
67
grpc .ChainStreamInterceptor (
70
- tags .StreamServerInterceptor (tags .WithFieldExtractor (tags .CodeGenRequestFieldExtractor )),
71
68
logging .StreamServerInterceptor (kit .InterceptorLogger (logger )),
72
69
),
73
70
)
@@ -78,7 +75,7 @@ func ExampleWithDecider() {
78
75
logger := log .NewNopLogger ()
79
76
// Shared options for the logger, with a custom decider that log everything except successful calls from "/blah.foo.healthcheck/Check" method.
80
77
opts := []logging.Option {
81
- logging .WithDecider (func (methodFullName string ) logging.Decision {
78
+ logging .WithDecider (func (methodFullName string , err error ) logging.Decision {
82
79
// will not log gRPC calls if it was a call to healthcheck and no error was raised
83
80
if methodFullName == "/blah.foo.healthcheck/Check" {
84
81
return logging .NoLogCall
@@ -90,11 +87,9 @@ func ExampleWithDecider() {
90
87
// Create a server, make sure we put the tags context before everything else.
91
88
_ = []grpc.ServerOption {
92
89
grpc .ChainUnaryInterceptor (
93
- tags .UnaryServerInterceptor (),
94
90
logging .UnaryServerInterceptor (kit .InterceptorLogger (logger ), opts ... ),
95
91
),
96
92
grpc .ChainStreamInterceptor (
97
- tags .StreamServerInterceptor (),
98
93
logging .StreamServerInterceptor (kit .InterceptorLogger (logger ), opts ... ),
99
94
),
100
95
}
@@ -104,21 +99,21 @@ func ExampleServerPayloadLoggingDecider() {
104
99
// Logger is used, allowing pre-definition of certain fields by the user.
105
100
logger := log .NewNopLogger ()
106
101
// Expect payload from "/blah.foo.healthcheck/Check" call to be logged.
107
- payloadDecider := func (ctx context.Context , fullMethodName string , servingObject interface {}) bool {
108
- return fullMethodName == "/blah.foo.healthcheck/Check"
102
+ payloadDecider := func (ctx context.Context , fullMethodName string , servingObject interface {}) logging.PayloadDecision {
103
+ // return fullMethodName == "/blah.foo.healthcheck/Check"
104
+ // TODO Fix
105
+ return 0
109
106
}
110
107
111
108
// Create a server, make sure we put the tags context before everything else.
112
109
_ = []grpc.ServerOption {
113
110
grpc .ChainUnaryInterceptor (
114
- tags .UnaryServerInterceptor (),
115
111
logging .UnaryServerInterceptor (kit .InterceptorLogger (logger )),
116
- logging .PayloadUnaryServerInterceptor (kit .InterceptorLogger (logger ), payloadDecider ),
112
+ logging .PayloadUnaryServerInterceptor (kit .InterceptorLogger (logger ), payloadDecider , time . RFC3339Nano ),
117
113
),
118
114
grpc .ChainStreamInterceptor (
119
- tags .StreamServerInterceptor (),
120
115
logging .StreamServerInterceptor (kit .InterceptorLogger (logger )),
121
- logging .PayloadStreamServerInterceptor (kit .InterceptorLogger (logger ), payloadDecider ),
116
+ logging .PayloadStreamServerInterceptor (kit .InterceptorLogger (logger ), payloadDecider , time . RFC3339Nano ),
122
117
),
123
118
}
124
119
}
0 commit comments